This repository has been archived by the owner on May 9, 2022. It is now read-only.
feat(rtc_types): add enclave_messages, with set_access_key #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiDelport
force-pushed
the
feat-types-enclave-messages
branch
from
cce761b to
a5fbec2
Compare
Nghondzweni
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
@PiDelport I see you refactored the set_access_key enclave_mesages code into the ffi_set_access_key module and renamed REQUEST_SIZE to SET_ACCESS_KEY_REQUEST_SIZE. Will all other enclave messages be defined this way? Also does this allow us now to define request sizes without conflicts?
|
@Nghondzweni: Yeah, for now, it looks like we'll have to use this approach to have both generic and non-generic versions of the types, for FFI purposes. If / when cbindgen gets better support for creating bindings for const generic types, we'll hopefully be able to drop these, but we'll have to follow the upstream issues for that. |
Non-generic version of [`set_access_key`], with conversions. This is a workaround for cbindgen not supporting const generics in structs yet, and should be removed once cbindgen implements that. Tracking issue: <mozilla/cbindgen#687>
…andling issues Issues: * mozilla/cbindgen#7 * mozilla/cbindgen#286 * mozilla/cbindgen#573
…EncryptedRequest as AAD
PiDelport
force-pushed
the
feat-types-enclave-messages
branch
from
a5fbec2 to
9c50c82
Compare
|
(Rebased to refresh.) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting functionality for issue #37
Precedes PR #87