-
Notifications
You must be signed in to change notification settings - Fork 0
Add implementation for execution token issuance #99
Conversation
2535d60
to
16f302d
Compare
There is still some todos that need looking at, and the type names need to be refactored as well. The bulk of the functionality should be here for review though. |
772c108
to
ae43415
Compare
ae43415
to
ac386d5
Compare
(Rebased to refresh) |
ac386d5
to
cf9f74d
Compare
TODO: Add in the size of the dataset into the execution token. |
5a38881
to
10a3d51
Compare
I rebased to capture the enum naming changes, and tweaked the new imports to be |
…ll-sgx and serde-json-sgx Link to the relevant HACKING.md section.
10a3d51
to
66151a8
Compare
This was pulling in duplications of I took a stab at documenting and fixing this a bit better:
|
(This closes #38, right?) |
Co-authored-by: Pi Delport <pi@registree.io>
@PiDelport @Nghondzweni . Please have a look at the latest commit diff. I think this wraps up all the feedback, so just double check if there is anything else. Thanks for the reviews! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@longtomjr: This works, but it might be simpler to use an [out]
variable for the buffer capacity used, instead of adding the IssueTokenResponse
struct for that?
This seems to be the go-to pattern for variable-sized ECALL out buffers: for example here and here.
I took a stab at amending 16084f7 to use that approach, in 50fb146, and the result looks a bit more like a pattern we'd want to standardise on:
- EDL: rtc_auth_enclave/rtc_auth.edl
- Inside enclave: rtc_auth_enclave/src/lib.rs
- Outside enclave: rtc_uenclave/src/enclaves/rtc_auth.rs
Does that look preferable to you too?
Followed up with @longtomjr: happy with the |
…sues Co-authored-by: Pi Delport <pi@registree.io>
16084f7
to
bd03587
Compare
No description provided.