Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS: fix Ja4 fingerprint computation #2419

Merged
merged 1 commit into from
May 5, 2024
Merged

Commits on May 5, 2024

  1. TLS: fix Ja4 fingerprint computation

    The new values has been checked against the ones reported by Wireshark.
    
    Found while fixing a Use-of-uninitialized-value error reported by
    oss-fuzz
    
    ```
    ==7582==WARNING: MemorySanitizer: use-of-uninitialized-value
        #0 0x5a6549abc368 in ndpi_compute_ja4 ndpi/src/lib/protocols/tls.c:1762:10
        ntop#1 0x5a6549ab88a0 in processClientServerHello ndpi/src/lib/protocols/tls.c:2863:10
        ntop#2 0x5a6549ac1452 in processTLSBlock ndpi/src/lib/protocols/tls.c:909:5
        ntop#3 0x5a6549abf588 in ndpi_search_tls_tcp ndpi/src/lib/protocols/tls.c:1098:2
        ntop#4 0x5a65499c53ec in check_ndpi_detection_func ndpi/src/lib/ndpi_main.c:7215:6
    ```
    
    See: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=68449&q=ndpi&can=1&sort=-id
    IvanNardi committed May 5, 2024
    Configuration menu
    Copy the full SHA
    7fea11a View commit details
    Browse the repository at this point in the history