Add enable/disable guessing using client IP/port #2569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add configurable options for whether to include client port or client IP in the flow's protocol guesses. This defaults to include both client port/IP if the protocol is not guessed with the server IP/port. This is intended for when flow direction detection is enabled, so we know that sport = client port, dport = server port.
IvanNardi
requested changes
Sep 24, 2024
There was a problem hiding this comment.
Overall, a good idea!
Other than the issue reported below, could you change the pcap used for the tests? We should use a trace triggering different results with and without this new configuration option
Remove 1kxun.pcap from both tests and use a link to:
- iphone.pcap for disable_use_client_ip
- bot.pcap for disable_use_client_ip
Add iphone.pcap for disable_use_client_ip Add bot.pcap for disable_use_client_port
|
I've assumed the bot.pcap was for disable_use_client_port |
|
|
@liwilson1, thank you (I fixed the tests while merging; the instructions I gave you were confused, sorry) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configurable options for whether to include client port or client IP in the flow's protocol guesses. This defaults to include both client port/IP if the protocol is not guessed with the server IP/port.
This is intended for when flow direction detection is enabled, so we know that sport = client port, dport = server port.
Please sign (check) the below before submitting the Pull Request:
Link to the related issue:
Describe changes:
Hi, please let me know if there is a better way to do this. We would like to disable using client IP + port when deciding the flow->guessed_protocol_id and flow->guessed_protocol_id_by_ip values.
I've created two new config options that enable/disable using the client port/ip when the server port/ip returns unknown.