-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update report-http.md #704
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hy! Great work with BGPalerter! i like to update the report documentation with a RocketChat Http Request Cheers
Thanks for this contribution. I changed the PR to be merged in dev. I have some remarks (1 is the most important):
Thanks |
Hi
To your points:
1. To be honest, it is working on both ways:
This way it seems to be fine as well!
----------------- %< -----------------
params:
templates:
default: '{"username": "BGPalerter ${channel}", "channel": "#BGPalerter", "text": "Channel: *${channel}* Type: *${type}* on Prefix *${prefix}* via Peer *${peers}* | Message Summary: ${summary}"}'
headers:
isTemplateJSON: true
----------------- %< -----------------
The trailing ' was lost in my pull request. but of course, it needed!
2. Channel is describe the RocketChat Channel. Users can create Channels as they like. Something like a "Room"
3. Yes of course, would make me proud! :-)
Cheers Adrian
On Fri. 3. December 2021 16:11 CET, Massimo Candela ***@***.***> wrote:
Thanks for this contribution. I changed the PR to be merged in dev.
I have some remarks (1 is the most important): * Are you sure the "payload=" part should be there? If I look at the documentation it looks like a JSON post body should be enough. Could you please verify that the example you provided works exactly as is (except for user-specific params). Be aware, the initial ' wrapping the payload is not closed. Please, if a string and a JSON post body are available, prefer the JSON one. * Can you describe the role of the "channel" key? * Are you ok with me adding "Thanks to @cadirol" at the bottom of the example?
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
…-- Adrian Kägi
Network Engineer
Direct +41 31 517 77 19 | Phone +41 31 517 77 77
NTS Workspace AG colocate lightspeed
Wölflistrasse 1d | CH-3006 Bern | www.nts.ch
|
I applied my review. Let me know if you are ok with it and if everything looks fine. Then, I will merge it. |
Seems good! your additional hint for #channel and @user completes the howto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hy!
Great work with BGPalerter!
i like to update the report documentation with a RocketChat Http Request
Cheers