Implement exceptions in Python and allow to retrieve meaningful information #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
==========================================
+ Coverage 87.73% 87.93% +0.20%
==========================================
Files 24 24
Lines 1622 1625 +3
Branches 79 74 -5
==========================================
+ Hits 1423 1429 +6
+ Misses 185 182 -3
Partials 14 14 |
sccolbert
reviewed
May 24, 2023
sccolbert
reviewed
May 24, 2023
sccolbert
reviewed
May 24, 2023
|
I am not saying it will. It's just for future-proofing and letting other
developers know that this module is imported by the core C extension.
…On Wed, May 24, 2023 at 2:37 PM Matthieu Dartiailh ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In py/kiwisolver/exceptions.py
<#162 (comment)>:
> @@ -0,0 +1,47 @@
+# --------------------------------------------------------------------------------------
+# Copyright (c) 2023, Nucleic Development Team.
+#
+# Distributed under the terms of the Modified BSD License.
+#
+# The full license is in the file LICENSE, distributed with this software.
+# --------------------------------------------------------------------------------------
+"""Kiwi exceptions."""
+
I am fine adding a comment but I do not see how that could cause a
circular import...
—
Reply to this email directly, view it on GitHub
<#162 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABBQSPDVDILGOARGAVPYTDXHZPQ5ANCNFSM6AAAAAAYN2K7WY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Got it. Thanks!
…On Wed, May 24, 2023 at 2:39 PM Matthieu Dartiailh ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In py/tests/test_solver.py
<#162 (comment)>:
> s.addEditVariable(v1, "medium")
- with pytest.raises(UnknownEditVariable):
+ assert e.value.edit_variable is v1
pytest.raises return a custom object ExcInfo. value is the way to reach
the original exception.
—
Reply to this email directly, view it on GitHub
<#162 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABBQSJZDT6QO224PRC6BLLXHZPXPANCNFSM6AAAAAAYN2K7WY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
As a side note @sccolbert could you allow codecov github app ? |
|
Done.
…On Wed, May 24, 2023 at 2:41 PM Matthieu Dartiailh ***@***.***> wrote:
As a side note @sccolbert <https://github.com/sccolbert> could you allow
codecov github app ?
—
Reply to this email directly, view it on GitHub
<#162 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABBQSJXBAPGFPR5DWNQXXDXHZP6HANCNFSM6AAAAAAYN2K7WY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Great ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step following the discussion in #161. Feel free to comment and suggest additional changes