Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.13 support #183

Merged
merged 13 commits into from
Sep 3, 2024
Merged

3.13 support #183

merged 13 commits into from
Sep 3, 2024

Conversation

MatthieuDartiailh
Copy link
Member

No description provided.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.88%. Comparing base (e7f7b86) to head (dd35b46).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
+ Coverage   87.86%   87.88%   +0.02%     
==========================================
  Files          24       24              
  Lines        1632     1635       +3     
  Branches       69       84      +15     
==========================================
+ Hits         1434     1437       +3     
  Misses        184      184              
  Partials       14       14              

@QuLogic
Copy link
Contributor

QuLogic commented Aug 21, 2024

If dropping 3.7 support, you can also remove the KIWI_DISABLE_FH4 flag, cf matplotlib/matplotlib#28725

@MatthieuDartiailh MatthieuDartiailh merged commit e8702fc into main Sep 3, 2024
51 of 52 checks passed
@MatthieuDartiailh MatthieuDartiailh deleted the 3.13-support branch September 3, 2024 16:14
@neutrinoceros
Copy link

Hi ! I don't know if that was intented, but I see that the 1.4.6 release only has one wheel for cp313. Namely, kiwisolver-1.4.6-cp313-cp313-win_arm64.whl

@MatthieuDartiailh
Copy link
Member Author

I just checked PyPI and I see much more than one. Can you re-check ?

@neutrinoceros
Copy link

FWIW, I'm still seeing just the one (looking at https://pypi.org/simple/kiwisolver/)
Could it be that I'm just served by an out-of-sync server ? I can just check again in an hour or so.

@QuLogic
Copy link
Contributor

QuLogic commented Sep 4, 2024

The build here shows only one 3.13 wheel being uploaded.

I think you may have run into the bug with upload-artifact/download-artifact that prompted their change to v4. To fix that, you would have to change uploading to use unique artifact names. See for example the GH104 error on repo-review, or the update in Matplotlib.

@MatthieuDartiailh
Copy link
Member Author

I did mess up the CI configuration. I fixed it and I am running a test run. If it passes I will upload the new wheels later today.

@neutrinoceros
Copy link

thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants