Continuous Integration

Remove symfony deprecations #2321

Triggered via push February 4, 2024 15:44

core23

pushed 12a0fba

3.2.x

Status Failure

Total duration 2m 34s

Artifacts –

continuous-integration.yml

on: push

run / Generate test matrix

Matrix: run / Code Coverage

Matrix: run / Coding Standards

Matrix: run / Lint composer.json

Matrix: run / Lint symfony container

Matrix: run / Mutation Tests

Matrix: run / Static Code Analysis

Matrix: run / Lint twig files

Matrix: run / Lint XLIFF files

Matrix: run / Lint YML files

Matrix: run / tests

Annotations

3 errors and 27 warnings

InternalClass: src/NucleosUserBundle.php#L44

src/NucleosUserBundle.php:44:41: InternalClass: Doctrine\Bundle\MongoDBBundle\DependencyInjection\Compiler\DoctrineMongoDBMappingsPass is internal to Doctrine but called from Nucleos\UserBundle\NucleosUserBundle (see https://psalm.dev/174)

InternalMethod: src/NucleosUserBundle.php#L44

src/NucleosUserBundle.php:44:41: InternalMethod: The method Doctrine\Bundle\MongoDBBundle\DependencyInjection\Compiler\DoctrineMongoDBMappingsPass::createXmlMappingDriver is internal to Doctrine but called from Nucleos\UserBundle\NucleosUserBundle::addRegisterMappingsPass (see https://psalm.dev/175)

run / Static Code Analysis (8.3)

Process completed with exit code 2.

run / Coding Standards (8.3)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

run / Lint composer.json (8.3)

run / Code Coverage (8.3)

run / Lint symfony container (8.3)

run / Lint twig files (8.3)

run / Static Code Analysis (8.3)

run / Mutation Tests (8.3)

run / Mutation Tests (8.3): src/Action/LoginAction.php#L65

Escaped Mutant for Mutator "MethodCallRemoval": --- Original +++ New @@ @@ public function __invoke(Request $request) : Response { $event = new GetResponseLoginEvent($request); - $this->eventDispatcher->dispatch($event, NucleosUserEvents::SECURITY_LOGIN_INITIALIZE); + if (null !== $event->getResponse()) { return $event->getResponse(); }

run / Mutation Tests (8.3): src/Action/LoginAction.php#L72

Escaped Mutant for Mutator "ArrayItemRemoval": --- Original +++ New @@ @@ if (null !== $event->getResponse()) { return $event->getResponse(); } - $form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'security.login.submit']); + $form = $this->formFactory->create(LoginFormType::class, null, ['method' => 'POST'])->add('save', SubmitType::class, ['label' => 'security.login.submit']); return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')])); } }

run / Mutation Tests (8.3): src/Action/LoginAction.php#L76

Escaped Mutant for Mutator "ArrayItemRemoval": --- Original +++ New @@ @@ if (null !== $event->getResponse()) { return $event->getResponse(); } - $form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'security.login.submit']); + $form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, []); return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')])); } }

run / Mutation Tests (8.3): src/Action/LoginAction.php#L83

Escaped Mutant for Mutator "ArrayItem": --- Original +++ New @@ @@ return $event->getResponse(); } $form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'security.login.submit']); - return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')])); + return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' > $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')])); } }

run / Mutation Tests (8.3): src/Action/LoginAction.php#L84

Escaped Mutant for Mutator "ArrayItem": --- Original +++ New @@ @@ return $event->getResponse(); } $form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'security.login.submit']); - return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')])); + return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' > $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')])); } }

run / Mutation Tests (8.3): src/Action/LoginAction.php#L85

Escaped Mutant for Mutator "ArrayItem": --- Original +++ New @@ @@ return $event->getResponse(); } $form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'security.login.submit']); - return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')])); + return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' > $this->csrfTokenManager->getToken('authenticate')])); } }

run / Mutation Tests (8.3): src/Action/RequestResetAction.php#L95

Escaped Mutant for Mutator "MethodCallRemoval": --- Original +++ New @@ @@ public function __invoke(Request $request) : Response { $form = $this->createForm(); - $form->handleRequest($request); + if ($form->isSubmitted() && $form->isValid()) { $response = $this->process($request); $this->getFlashBag($request)?->add('success', $this->translator->trans('resetting.check_email', ['%tokenLifetime%' => ceil($this->retryTtl / 3600)], 'NucleosUserBundle'));

run / Mutation Tests (8.3): src/Action/RequestResetAction.php#L97

Escaped Mutant for Mutator "LogicalAndSingleSubExprNegation": --- Original +++ New @@ @@ { $form = $this->createForm(); $form->handleRequest($request); - if ($form->isSubmitted() && $form->isValid()) { + if ($form->isSubmitted() && !$form->isValid()) { $response = $this->process($request); $this->getFlashBag($request)?->add('success', $this->translator->trans('resetting.check_email', ['%tokenLifetime%' => ceil($this->retryTtl / 3600)], 'NucleosUserBundle')); if (null !== $response) {

run / Mutation Tests (8.3): src/Action/RequestResetAction.php#L198

Escaped Mutant for Mutator "ArrayItemRemoval": --- Original +++ New @@ @@ } private function createForm() : FormInterface { - return $this->formFactory->create(RequestPasswordFormType::class, null, ['action' => $this->router->generate('nucleos_user_resetting_request'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'resetting.request.submit']); + return $this->formFactory->create(RequestPasswordFormType::class, null, ['method' => 'POST'])->add('save', SubmitType::class, ['label' => 'resetting.request.submit']); } }

run / Mutation Tests (8.3): src/Action/RequestResetAction.php#L202

Escaped Mutant for Mutator "ArrayItemRemoval": --- Original +++ New @@ @@ } private function createForm() : FormInterface { - return $this->formFactory->create(RequestPasswordFormType::class, null, ['action' => $this->router->generate('nucleos_user_resetting_request'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'resetting.request.submit']); + return $this->formFactory->create(RequestPasswordFormType::class, null, ['action' => $this->router->generate('nucleos_user_resetting_request'), 'method' => 'POST'])->add('save', SubmitType::class, []); } }

run / Lint XLIFF files (8.3)