Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Max timeout for get_ursulas/bucket_sampling; fix faulty env variable usage #77

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

derekpierre
Copy link
Member

@derekpierre derekpierre commented Sep 9, 2024

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR addresses a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on?
Is there a particular commit/function/section of your PR that requires more attention from reviewers?

Ensure that environment variables are cast to integers.
Increase max timeout (for now) for get_ursulas/bucket_sampling.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.57%. Comparing base (d540b7c) to head (8224acc).

Additional details and impacted files
@@               Coverage Diff               @@
##           development      #77      +/-   ##
===============================================
+ Coverage        90.55%   90.57%   +0.02%     
===============================================
  Files               18       18              
  Lines              900      902       +2     
===============================================
+ Hits               815      817       +2     
  Misses              85       85              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theref
Copy link

theref commented Sep 10, 2024

separate investigation can be done into efficiency improvments

is there an issue for this?

Copy link

@theref theref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it

@derekpierre
Copy link
Member Author

separate investigation can be done into efficiency improvments

is there an issue for this?

There is one now - #78 - 😆

@derekpierre derekpierre merged commit e1b0550 into nucypher:development Sep 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants