Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.9.0 #129

Merged
merged 9 commits into from
Dec 7, 2022
Merged

Release 0.9.0 #129

merged 9 commits into from
Dec 7, 2022

Conversation

piotr-roslaniec
Copy link
Contributor

@piotr-roslaniec piotr-roslaniec commented Dec 7, 2022 •
edited
Loading

  • Update examples after v0.9.0 release

@piotr-roslaniec piotr-roslaniec marked this pull request as ready for review December 7, 2022 11:01
@piotr-roslaniec piotr-roslaniec added the do not merge Open for review but do not merge please label Dec 7, 2022
theref
theref reviewed Dec 7, 2022
View reviewed changes
Copy link
Contributor

@theref theref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we possible need to split it into two PRs.

  1. Release 0.9.0
  2. Upgrade all the examples to use the new Release

examples/react-craco/package.json
@@ -12,7 +12,7 @@
},
"dependencies": {
"@craco/craco": "^6.4.3",
"@nucypher/nucypher-ts": "^0.7.0",
"@nucypher/nucypher-ts": "0.9.0-alpha.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer alpha i think

examples/react-webpack-5-experiments/package.json
"file-loader": "^6.2.0",
"@nucypher/nucypher-ts": "^0.7.0",
"@nucypher/nucypher-ts": "0.9.0-alpha.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@piotr-roslaniec
Copy link
Contributor Author

So the reason why examples are using 0.9.0-alpha.1 is that it's pretty much compatible with 0.9.0. I'm going to update them after releasing the v0.9.0 package on npmjs.com

@piotr-roslaniec piotr-roslaniec mentioned this pull request Dec 7, 2022
Closed
@piotr-roslaniec piotr-roslaniec removed the do not merge Open for review but do not merge please label Dec 7, 2022
@piotr-roslaniec piotr-roslaniec merged commit 83ad789 into nucypher:main Dec 7, 2022
@piotr-roslaniec piotr-roslaniec deleted the release-0.9.0 branch December 7, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theref theref theref approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piotr-roslaniec @theref