Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the code that drains the response body #9

Closed
vvatanabe opened this issue May 7, 2018 · 1 comment
Closed

Remove the code that drains the response body #9

vvatanabe opened this issue May 7, 2018 · 1 comment
Assignees
@vvatanabe
Labels
enhancement

Comments

@vvatanabe
Copy link
Member

It has already been fixed in the Golang 1.7+.
refs: google/go-github#317
@vvatanabe vvatanabe self-assigned this May 7, 2018
vvatanabe added a commit that referenced this issue May 7, 2018
@vvatanabe
remove the code that drains the response body (#9)
a0004ba
vvatanabe added a commit that referenced this issue May 7, 2018
@vvatanabe
Merge pull request #10 from nulab/issue-9/remove-the-code-that-drains…
74a76a4 
…-the-response-body

remove the code that drains the response body (#9)
@joytry1
Copy link

joytry1 commented May 25, 2020

hi, I'm try to figure out the HTTP connections reuse.
After I saw the docs, it seems still need to drain response.Body now.
golang/go@246e6ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vvatanabe vvatanabe

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joytry1 @vvatanabe