Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow _source_includes and _source_excludes for GET search requests #268

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Allow _source_includes and _source_excludes for GET search requests #268

merged 1 commit into from
Oct 9, 2024

Conversation

kdid
Copy link
Contributor

@kdid kdid commented Oct 9, 2024 •
edited
Loading

Summary

  • Allow consumers to specify fields for include and exclude in GET /search requests.
  • Ex: _source_includes=title,date_created,accesssion_number and _source_excludes=embedding

@kdid kdid self-assigned this Oct 9, 2024
bmquinn
bmquinn approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@bmquinn bmquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

@kdid kdid merged commit 7ba44d6 into deploy/staging Oct 9, 2024
1 check passed
@kdid kdid deleted the 5230-no-embedding branch October 9, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmquinn bmquinn bmquinn approved these changes

Assignees

@kdid kdid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdid @bmquinn