Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xcode 8 #46

Closed
drewwells opened this issue Sep 20, 2016 · 7 comments
Closed

xcode 8 #46

drewwells opened this issue Sep 20, 2016 · 7 comments
Assignees
Labels

Comments

@drewwells
Copy link

drewwells commented Sep 20, 2016

I'm seeing errors in xcode 8

RCTAutoComplete.m:98:34: warning:
      'sendInputEventWithName:body:' is deprecated: Use RCTDirectEventBlock or RCTBubblingEventBlock instead [-Wdeprecated-declarations]
    [self.bridge.eventDispatcher sendInputEventWithName:@"topChange" body:event];
                                 ^
In file included from .../ui/node_modules/react-native-autocomplete/RCTAutoComplete.m:2:
In file included from .../ui/node_modules/react-native-autocomplete/RCTAutoComplete.h:2:
In file included from ../../node_modules/react-native/React/Views/RCTViewManager.h:15:
../../node_modules/react-native/React/Base/RCTEventDispatcher.h:76:1: note: 'sendInputEventWithName:body:' has been explicitly marked
      deprecated here
- (void)sendInputEventWithName:(NSString *)name body:(NSDictionary *)body
^
2 warnings and 4 errors generated.

** BUILD FAILED **
@nulrich nulrich added the bug label Sep 20, 2016
@nulrich nulrich self-assigned this Sep 20, 2016
@drewwells
Copy link
Author

@nulrich
Copy link
Owner

nulrich commented Sep 21, 2016

Thanks! I think it can also comes from facebook/react-native@d973757
I will replace the EventDispatcher.

@nulrich
Copy link
Owner

nulrich commented Sep 27, 2016

I started to clean up the code for Xcode 8 in branch #46. I will fix the Objective-C code and also move JS code to ES6.

@drewwells
Copy link
Author

🎆 💥 !

@nulrich
Copy link
Owner

nulrich commented Sep 28, 2016

I fixed Objective-C part. You were correct, the problem was coming from RCTFont. But your error log was not complet ;-) so I first thought the issue was coming from the EventDispatcher (which I will soon need to fix anyway).

I should be done with JS code by the end of the week, but you can already start to use what is on the branch #46 (checkout code and npm install path-to-RCTAutoComplete).

@drewwells
Copy link
Author

Sweet I'll give it a spin

On Wed, Sep 28, 2016, 5:04 PM Nicolas Ulrich notifications@github.com
wrote:

I fixed Object-C part. You were correct, the problem was coming from
RCTFont. But your error log was not complet ;-) so I first thought the
issue was coming from the EventDispatcher (which I will soon need to fix
anyway).

I should be done with JS code by the end of the week, but you can already
start to use what is on the branch #46
#46 (checkout code and
npm install path-to-RCTAutoComplete).


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#46 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOmE8qMFyzB8TrTavbigIswUWgiUVdbks5quuRggaJpZM4KBOon
.

@drewwells
Copy link
Author

It works!

@nulrich nulrich closed this as completed in b3894d0 Oct 1, 2016
nulrich pushed a commit that referenced this issue Oct 1, 2016
Fix #46 Use RCTFont instead of RCTConvert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants