Fix / workaround for OrcJIT blocking issues #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since OrcJIT is still experimental, and there seem to be some issues on platforms we don't regularly test on (e.g. Issue numba#1000), it seems prudent to simply skip the OrcJIT tests on non-x86 platforms.
gmarkall
added a commit
to gmarkall/llvmlite-feedstock
that referenced
this pull request
Oct 12, 2023
gmarkall
changed the title
gmarkall
changed the title
|
This is now passing on conda-forge: conda-forge/llvmlite-feedstock#76 |
`Py_GetVersion()` does not exist on PyPy, but `PyPy_GetVersion()` does.
gmarkall
force-pushed
the
skip-orcjit-non-x86
branch
from
77634b0 to
dbc1bf1
Compare
Thank you! |
esc
approved these changes
Oct 12, 2023
esc
added a commit
to esc/llvmlite
that referenced
this pull request
Oct 12, 2023
Fix / workaround for OrcJIT blocking issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since OrcJIT is still experimental, and there seem to be some issues on platforms we don't regularly test on (e.g. Issue #1000), it seems prudent to simply skip the OrcJIT tests on non-x86 platforms.
It also deals with the lack of
Py_GetVersion(), on PyPy, which causes an error running the tests - on PyPyPyPy_GetVersion()is used instead.Fixes #1003.