Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial commit #285

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Initial commit #285

wants to merge 1 commit into from

Conversation

AlexanderKalistratov
Copy link
Contributor

Please review these guidelines to help with the review process:

  • Have you provided a meaningful PR description?
  • Have you added a test, a reproducer, or a reference to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?
  • Have you organized your commits logically and ensured each can be built by itself?

Hardcode84
Hardcode84 reviewed Oct 7, 2023
View reviewed changes
numba_mlir/numba_mlir/mlir_compiler/lib/pipelines/PlierToLinalg.cpp
if (!mlir::isa_and_nonnull<AllocOp, AllocaOp>(opDefOp))
continue;

auto linGen = hasOnlyCopyUser(operand);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to also check if there are no side-effecting ops between call and copy op.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hardcode84 Hardcode84 Hardcode84 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderKalistratov @Hardcode84