Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added release notes for Version 0.4 #100

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Conversation

oliverfunk
Copy link
Contributor

Closes #97

@esc I used the script you linked to in the issue to generate the change log. Please review so a new release can be cut. Many of us need the new version now.

Thanks!

Oliver

@oliverfunk
Copy link
Contributor Author

@esc btw I used

gitlog2changelog.py --token=<token> --beginning=bd99bb687814269e95c3ef2aedf23144c1436eff --repo=numba/numba-scipy --digits=2 --summary

That commit hash was the one version 0.3 branched from.

@esc
Copy link
Member

esc commented Mar 18, 2024

@oliverfunk thank you, noted! Your efforts here are much appreciated and will hopefully enable a release soon. I just looked at my schedule and will hopefully have some time during the week starting 8th of April.

@esc
Copy link
Member

esc commented Apr 8, 2024

@oliverfunk thank you, noted! Your efforts here are much appreciated and will hopefully enable a release soon. I just looked at my schedule and will hopefully have some time during the week starting 8th of April.

Picking this up now.

@esc
Copy link
Member

esc commented Apr 8, 2024

having trouble re-running Azure -- will open/close.

@esc esc closed this Apr 8, 2024
@esc esc reopened this Apr 8, 2024
@esc
Copy link
Member

esc commented Apr 8, 2024

Building with 3.12 may be potentially broken:

 💣 zsh» python setup.py develop
/Users/esc/git/numba-scipy/versioneer.py:421: SyntaxWarning: invalid escape sequence '\s'
  LONG_VERSION_PY['git'] = '''
Traceback (most recent call last):
  File "/Users/esc/git/numba-scipy/setup.py", line 11, in <module>
    version=versioneer.get_version(),
            ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/esc/git/numba-scipy/versioneer.py", line 1480, in get_version
    return get_versions()["version"]
           ^^^^^^^^^^^^^^
  File "/Users/esc/git/numba-scipy/versioneer.py", line 1412, in get_versions
    cfg = get_config_from_root(root)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/esc/git/numba-scipy/versioneer.py", line 342, in get_config_from_root
    parser = configparser.SafeConfigParser()
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'configparser' has no attribute 'SafeConfigParser'. Did you mean: 'RawConfigParser'

@esc
Copy link
Member

esc commented Apr 8, 2024

Seems like it does build with python 3.11 -- but I guess 3.12 support is what we want in a release now, so I'll go make a ticket and PR for it.

@esc esc added this to the 0.4.0 milestone Apr 8, 2024
@esc esc mentioned this pull request Apr 8, 2024
@esc
Copy link
Member

esc commented Apr 8, 2024

Versioneer to support 3.12 is here: #102

@esc
Copy link
Member

esc commented Apr 9, 2024

FYI: with #103 merged, I took the liberty to rebase this onto main at 03f9c2a

@esc
Copy link
Member

esc commented Apr 9, 2024

Looking at the list of PRs in the changelog, I think some of them have already been added to 0.3.1 so the changelog might need to be fixed up some more.

@esc
Copy link
Member

esc commented Apr 9, 2024

Looking at the list of PRs in the changelog, I think some of them have already been added to 0.3.1 so the changelog might need to be fixed up some more.

It looks like a bunch of PRs were backported for the 0.3.1 release -- as a result I would argue that these would need to be removed from the changelog entry for 0.4

Screenshot 2024-04-09 at 16 27 57

@esc
Copy link
Member

esc commented Apr 9, 2024

Looking at the list of PRs in the changelog, I think some of them have already been added to 0.3.1 so the changelog might need to be fixed up some more.

It looks like a bunch of PRs were backported for the 0.3.1 release -- as a result I would argue that these would need to be removed from the changelog entry for 0.4

Screenshot 2024-04-09 at 16 27 57

Those changes have been made in c977a14

@esc
Copy link
Member

esc commented Apr 9, 2024

#102 was merged and will be included in 0.4 -- I've updated the changelog accordingly.

@esc
Copy link
Member

esc commented Apr 9, 2024

@oliverfunk together with @sklam we decided to not include an upgrade to 3.12 in 0.4 and instead release what we have now and include 3.12 in 0.5 -- apparently this also needs scipy in 1.12 as a minimum, which is higher than what 0.4 supports.

Copy link
Member

@sklam sklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esc esc merged commit b5f042f into numba:main Apr 9, 2024
31 checks passed
@oliverfunk
Copy link
Contributor Author

@esc amazing! Thank you.
Yeah supporting py3.12 in 0.5 makes sense.
Cheers!

@esc
Copy link
Member

esc commented Apr 10, 2024

@esc amazing! Thank you. Yeah supporting py3.12 in 0.5 makes sense. Cheers!

No worries. FWIW: this project is open to additional maintainers, in case that "tickles your fancy". 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package new release to include latest patch change (version 0.3.2)
3 participants