-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support LowLevelCallable #2999
Support LowLevelCallable #2999
Conversation
Typing for scipy specific features | ||
""" | ||
from numba import types | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This creates an import cycle, which appears to be handled properly in Python 3, but not Python 2.
Codecov Report
@@ Coverage Diff @@
## master #2999 +/- ##
==========================================
+ Coverage 85.73% 85.74% +<.01%
==========================================
Files 327 331 +4
Lines 68535 68630 +95
Branches 7755 7759 +4
==========================================
+ Hits 58760 58845 +85
- Misses 8535 8544 +9
- Partials 1240 1241 +1 |
and fixes the ctypes test expected value.
xref #2995 (comment) |
I'm very keen on this functionality and it seems like it's very nearly there so I'm curious if it will make the cutoff for 0.40.0? |
Ping! It seems like this PR is most of the way there. Is there anything in particular holding it up? I'm hopeful that it will resolve #2578 as well. |
My comment at #2995 (comment) is not addressed so far at least. |
This pull request is marked as stale as it has had no activity in the past 3 months. Please respond to this comment if you're still interested in working on this. Many thanks! |
It would be sad to see this being closed... but well, as a simple occasional user I'm really not the one who can help and I won't pretend understanding a single line of code behind this PR! |
This pull request is marked as stale as it has had no activity in the past 3 months. Please respond to this comment if you're still interested in working on this. Many thanks! |
Fix #2995