-
Notifications
You must be signed in to change notification settings - Fork 1.6k
NUP-2397: rename TP* to TM* #3555
NUP-2397: rename TP* to TM* #3555
Conversation
* TPShimMixin to TMShimMixin * TPShim to TMShim * MonitoredTPShim to MonitoredTMShim * FastTPShim to FastTMShim * TPCPPShim to TMCPPShim
@marionleborgne Will review today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very thorough, good job. I found a few things, nothing major.
examples/NuPIC Walkthrough.ipynb
Outdated
@@ -674,7 +674,7 @@ | |||
"outputs": [], | |||
"source": [ | |||
"# Step 1: create Temporal Pooler instance with appropriate parameters\n", | |||
"tp = TP(numberOfCols=50, cellsPerColumn=2,\n", | |||
"tm = TP(numberOfCols=50, cellsPerColumn=2,\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this constructor call still valid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so (with BacktrackignTM
). I fixed the notebook, and everything executes properly now.
examples/tm/tm_constant_test.py
Outdated
seed=SEED, verbosity=VERBOSITY, | ||
checkSynapseConsistency=True, | ||
pamLength=1000) | ||
cppTp = BacktrackingTMCPP(numberOfCols=numCols, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change cppTp
==> cppTm
examples/tm/tm_constant_test.py
Outdated
globalDecay=globalDecay, burnIn=1, | ||
seed=SEED, verbosity=VERBOSITY, | ||
pamLength=1000) | ||
pyTp = BacktrackingTM(numberOfCols=numCols, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change pyTp
==> pyTm
src/nupic/math/roc_utils.py
Outdated
@@ -229,7 +229,7 @@ def _test(): | |||
1 0.3 0 0 0 1 1 | |||
1 0.45 0 1 1 1 1 | |||
|
|||
TruePos(TP) 1 2 2 3 3 | |||
TruePos(TM) 1 2 2 3 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This TM
should not be replaced because it means TruePos
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I missed that
src/nupic/math/roc_utils.py
Outdated
@@ -238,7 +238,7 @@ def _test(): | |||
The ROC curve is a plot of FPR on the x-axis and TPR on the y-axis. Basically, | |||
one can pick any operating point along this curve to run, the operating point | |||
determined by which threshold you want to use. By changing the threshold, you | |||
tradeoff TP's for FPs. | |||
tradeoff TM's for FPs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
@rhyolight thanks for the feedback. I addressed your comments. |
@marionleborgne Thanks, you'll need to merge. |
…97-rename-tp-to-tm # Resolved conflicts with: # docs/examples/opf/model_params.py # examples/opf/experiments/anomaly/spatial/10field_many_balanced/UNDER_DEVELOPMENT # examples/opf/experiments/anomaly/spatial/10field_many_balanced/description.py # examples/opf/experiments/anomaly/temporal/noisy_saw/UNDER_DEVELOPMENT # examples/opf/experiments/anomaly/temporal/noisy_saw/description.py # examples/opf/experiments/anomaly/temporal/saw_200_category/UNDER_DEVELOPMENT # examples/opf/experiments/anomaly/temporal/saw_200_category/description.py # tests/unit/nupic/frameworks/opf/htmpredictionmodel_classifier_helper_test.py
@rhyolight I merged. It's ready for you to review again. |
Fixes #3556
Name changes:
TPRegion
toTMRegion
TP
toBacktrackingTM
TP10X*
toBacktrackingTMCPP
TPShim*
toTMShim*
TP / temporal pooling
toTM / temporal memory
.