-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Conversation
# ensures that recordNum increases monotonically | ||
if len(self._patternNZHistory) > 0: | ||
if recordNum < self._patternNZHistory[-1][0]: | ||
raise ValueError("the record number has to increase monotonically") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add to the docstring:
:raises: (ValueError) when record number does not increase monotonically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me once you address @rhyolight comment
@ywcui1990 - are you ready to merge this? I want to revalidate #3665 once this is merged to make sure the two changes are compatible. |
@scottpurdy I am ready to merge this. I will push a separate PR in nupic.core. I expect this PR to break regression tests since it affects classification/prediction accuracy. Do you know why the regression tests pass with this PR? |
I believe the regression tests only run on a nightly for master, not PRs. @rhyolight - is that right? |
@scottpurdy Yes, it's nightly on master only. |
Fixes: #3651
Summary
@scottpurdy This is a fix for the broken SDR classifier. If this looks good to you, I will make the same change in nupic.core