Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistency with 1 dof #55

Merged
merged 2 commits into from
Dec 31, 2023
Merged

Fix inconsistency with 1 dof #55

merged 2 commits into from
Dec 31, 2023

Conversation

lxvm
Copy link
Contributor

@lxvm lxvm commented Dec 30, 2023

Hi,

I noticed an issue where if the integrand has one degree of freedom, but is a vector, I would get a type conversion error. I've fixed it by letting broadcasting figure out the size of the integrand and I added an interface test that checks this case. I hope this wouldn't break much code since it looked like the implementation implicitly assumes the integrand returns either a number or vector and not a multidimensional array.

@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (22c9e72) 85.03% compared to head (c60a160) 84.97%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   85.03%   84.97%   -0.06%     
==========================================
  Files          20       16       -4     
  Lines        1410     1398      -12     
==========================================
- Hits         1199     1188      -11     
+ Misses        211      210       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kunyuan kunyuan requested review from kunyuan and iintSjds December 31, 2023 02:03
@kunyuan
Copy link
Member

kunyuan commented Dec 31, 2023

Thank you for fixing this issue!

@kunyuan kunyuan merged commit 4958e41 into numericalEFT:master Dec 31, 2023
5 checks passed
@lxvm
Copy link
Contributor Author

lxvm commented Dec 31, 2023

Thank you @kunyuan ! It would be great if this could be added to the next patch release

@lxvm lxvm deleted the 1dof branch December 31, 2023 03:12
@kunyuan
Copy link
Member

kunyuan commented Dec 31, 2023

We will be submitting a patch release soon. Thank you once again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants