Skip to content
This repository has been archived by the owner on Jun 10, 2020. It is now read-only.

Continuous integration tests #3

Closed
shoyer opened this issue Dec 6, 2017 · 7 comments
Closed

Continuous integration tests #3

shoyer opened this issue Dec 6, 2017 · 7 comments

Comments

@shoyer
Copy link
Member

shoyer commented Dec 6, 2017

What should these look like?

At the least, we probably should verify that mypy can successfully type-check some simple examples using these type annotations.

@henryJack
Copy link

Happy to write the example annotated code once the stubs are done. It's probably best to add a mypy job to the pipeline with multiple scripts testing that mypy passes and throws errors where it's supposed to.

@eric-wieser
Copy link
Member

I'm workin on #2, and I'm not even sure I'm able to test this locally - it seems mypy doesn't support _stubs packages yet.

@shoyer
Copy link
Member Author

shoyer commented Dec 6, 2017

It seems that we are very cutting edge here in relying on PEP 561. @ethanhs is still finishing up the mypy implementation in python/mypy#4278, but I guess we could test locally against his branch.

@shoyer
Copy link
Member Author

shoyer commented Dec 6, 2017

See python/typeshed#754 and python/typeshed#1339. It seems like tests for stubs make sense for at least tricky cases, but are probably overkill when required for everything.

@eric-wieser
Copy link
Member

We're probably going to want to use whatever mypy is using to run its own tests here. Perhaps to support PEP561, mypy should extract its testing module to be standalone

@emmatyping
Copy link
Contributor

The branch is in a somewhat limited state, it checks against packages installed only for the Python mypy is installed in. Just a heads up. It should work for the simple case.

@shoyer
Copy link
Member Author

shoyer commented Sep 12, 2019

We have this now.

@shoyer shoyer closed this as completed Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants