This repository has been archived by the owner on Jun 10, 2020. It is now read-only.
Setup Travis and correct setup.py #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoyer
reviewed
Feb 18, 2018
setup.py
Outdated
| @@ -13,6 +13,6 @@ | |||
| # PEP 561 requires these | |||
| install_requires=['numpy~=1.13.0'], | |||
|
Can you also add a Travis-CI link to the README? |
shoyer
reviewed
Feb 18, 2018
| @@ -1,7 +1,7 @@ | |||
| from setuptools import setup, find_packages | |||
|
|
|||
| setup( | |||
| name='numpy_stubs', | |||
| name='numpy-stubs', | |||
There was a problem hiding this comment.
I see that PEP 561 changed it's guidelines here. I suppose we should also rename this repository?
There was a problem hiding this comment.
This name (the distribution name) doesn't impact PEP 561 compliance. The package name is the real decider; when this repo starts using my PEP 561 implementation in mypy, it will need to rename the numpy package to numpy-stubs, and make according changes. Happy to do those changes when it is time.
|
And we're green! Thanks helping get thing set up here... I'll go ahead and merge shortly. |
alanhdu
pushed a commit
to alanhdu/numpy-stubs
that referenced
this pull request
Feb 18, 2018
* Replace tab in setup.py with spaces * Add Travis * Add flake8 config to pass tests * Use `-` instead of `_` See python/peps#568 * Add Travis badge to README * Use numpy 1.14.0
shoyer
pushed a commit
that referenced
this pull request
Feb 19, 2018
* Add some typehints * Add ctypes typehints * Add stubs for dtype * Setup Travis and correct setup.py (#8) * Replace tab in setup.py with spaces * Add Travis * Add flake8 config to pass tests * Use `-` instead of `_` See python/peps#568 * Add Travis badge to README * Use numpy 1.14.0 * Fix some type annotations * Make attributes read-only properties * Add metadata property * Move flags into flagobj * Add _Shape type alias * Alphabetize properties
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't really take an opinion on #3, but it at least sets up the basic sanity checks that this repo already has.