Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docscrape: fixes from SciPy #576

Merged
merged 2 commits into from
Jul 22, 2024
Merged

docscrape: fixes from SciPy #576

merged 2 commits into from
Jul 22, 2024

Conversation

lucascolley
Copy link
Contributor

x-ref scipy/scipy#21215 where we are bringing our vendored docscrape up to date with upstream. @mdhaber found a bug which is fixed here.

Also, our linter caught a warn without a stacklevel kwarg. Please consider adding ruff code B028 for this repo!

Co-authored-by: Matt Haberland <mdhaber@mit.edu>
Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, thanks @lucascolley !

@larsoner
Copy link
Collaborator

Agreed, in it goes!

@larsoner larsoner merged commit 97a6026 into numpy:main Jul 22, 2024
23 checks passed
@stefanv stefanv added this to the 1.8.0 milestone Jul 22, 2024
@lucascolley lucascolley deleted the scipy-fixes branch July 22, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants