Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating for Visual Studio 2022 #46

Merged
merged 5 commits into from
Jan 8, 2023
Merged

Updating for Visual Studio 2022 #46

merged 5 commits into from
Jan 8, 2023

Conversation

rprouse
Copy link
Member

@rprouse rprouse commented Dec 31, 2022

Continuing work on #43 properly updating the references and updating to the newer framework and adapter releases. Still needs testing. We may need to release a new version just for 2022 now that it is x64?

@rprouse rprouse self-assigned this Dec 31, 2022
@rprouse
Copy link
Member Author

rprouse commented Dec 31, 2022

@rprouse rprouse mentioned this pull request Dec 31, 2022
@OsirisTerje
Copy link
Member

OsirisTerje commented Jan 1, 2023

As written in the link you point to, we can create two installation targets for this extension so that it continues to work for VS2017/19. I believe that VS2017/19 will complain if we release this for VS2022 - they might say it can be updated since it is already installed, although it will not work since this new one will be for x64. So if we continue backward compatibility with 2017/19 we should have two installation targets. Not sure how that will affect the other changes though.

UPDATE: Just noticed you had given the extension a new identifier, so then it will not crash. That is probably for the best, but means we don't expect any support to the older ones.

@@ -39,6 +39,7 @@ public class NUnit2SolutionManager : SolutionManagerBase
{
private const string NUnitVersion = "2.6.4";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private const string NUnitVersion = "2.6.4";
private const string NUnitVersion = "2.7.1";

@OsirisTerje
Copy link
Member

OsirisTerje commented Jan 1, 2023

@rprouse

  1. Another thing, not sure if we should continue the support of NUnit 2 ?
  2. You mention needing more testing - what is needed, or what is, or not, been tested?
  3. We need to update the readme

@rprouse
Copy link
Member Author

rprouse commented Jan 2, 2023

  • I agree about dropping NUnit 2. I haven't even tested it.
  • I've only done some light testing on it so far. I'd like to do some more.
  • Dropping support for old versions; we haven't updated this in a long time and I don't think it works properly in 2019. Cut our losses?

@rprouse
Copy link
Member Author

rprouse commented Jan 8, 2023

@OsirisTerje I am going to merge this and remove NUnit2 in another PR to keep them separate.

@rprouse rprouse merged commit 7b67ca6 into master Jan 8, 2023
@rprouse rprouse deleted the shaoyy-master branch January 8, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants