NRE in AnalyzePositionalArgumentsAndParameters

[mikkelbu]

In the method TestCaseUsageAnalyzer.AnalyzePositionalArgumentsAndParameters there is the assumption that all expressions in the attribute has type LiteralExpressionSyntax. This is not always the case. The assumption fails in e.g. nunit.nunit\src\NUnitFramework\tests\Constraints\MsgUtilTests.cs, where we have the constant s52 which hence has type IdentifierNameSyntax.

        private const string s52 = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ";

        [TestCase(s52, 52, 0, s52, TestName="NoClippingNeeded")]
        [TestCase(s52, 29, 0, "abcdefghijklmnopqrstuvwxyz...", TestName="ClipAtEnd")]
        [TestCase(s52, 29, 26, "...ABCDEFGHIJKLMNOPQRSTUVWXYZ", TestName="ClipAtStart")]
        [TestCase(s52, 28, 26, "...ABCDEFGHIJKLMNOPQRSTUV...", TestName="ClipAtStartAndEnd")]
        public static void TestClipString(string input, int max, int start, string result)
        {
            System.Console.WriteLine("input=  \"{0}\"", input);
            System.Console.WriteLine("result= \"{0}\"", result);
            Assert.That(MsgUtils.ClipString(input, max, start), Is.EqualTo(result));
        }

[mikkelbu]

It also fails in the following cases:

• When the argument is a negative number -4 => PrefixUnaryExpressionSyntax.
• When the argument is a cast => CastExpressionSyntax.