Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not replace line breaks in code fixes #160

Merged
merged 2 commits into from
Oct 26, 2019

Conversation

Dreamescaper
Copy link
Member

Example.

Code with diagnostic:

            Assert.AreEqual(expected, actual,
                "Some Test Message",
                "With format");

Code fix before PR:

            Assert.That(actual, Is.EqualTo(expected), "Some Test Message", "With format");

Code fix after PR:

            Assert.That(actual, Is.EqualTo(expected),
                "Some Test Message",
                "With format");

Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The only thing I was considering was whether we should have a proper guard that there are elements in newArguments in WithArguments - instead of just failing when calling First().

But examining the calling code this is the case now, so I think we should leave it as it is.

Thanks for the contribution 😄.

@mikkelbu mikkelbu merged commit 648897c into nunit:master Oct 26, 2019
@Dreamescaper Dreamescaper deleted the do_not_replace_line_breaks branch October 26, 2019 18:28
@mikkelbu mikkelbu added this to the Release 0.2 milestone Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants