Fix EqualToIncompatibleTypes for nullable enums #180
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #179
Another small one :)
Problem that I've encountered was specifically about nullable enums.
Thing is that conversion from
EnumOne?
toEnumTwo?
exists and it isNullableExplicit
.But it is same
NullableExplcit
for nullable to non-nullable type, e.g.EnumOne?
->EnumOne
.Therefore we cannot rely solely on conversion information, so I handle nullability case separately.