New project format and netstandard for analyzer project #19
Conversation
mikkelbu
changed the title
|
Hi @JohanLarsson thanks for the contribution. I've been going a bit back and forth on whether to use the new project format (see e.g. #16), but I think that I've come to the conclusion that the new format is the way to go. Hopefully, I'll have time to look at this PR tomorrow evening, as the last week was completely packed. |
|
If nothing else the new format diffs nicer. I moved to new format for all my analyzer projects and it has worked ok. Only issue really is the vsix that needs a few hax. |
|
@JohanLarsson I've been using |
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" /> | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <MinimumVisualStudioVersion>11.0</MinimumVisualStudioVersion> |
There was a problem hiding this comment.
Should this still be in the project-file?
There was a problem hiding this comment.
Not sure, that is why I left it there, came from the old project.
There was a problem hiding this comment.
This file will only open in VS2017 or later, so it could be removed.
| <Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" /> | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <Import Project="..\packages\NUnit.3.10.1\build\NUnit.props" Condition="Exists('..\packages\NUnit.3.10.1\build\NUnit.props')" /> |
There was a problem hiding this comment.
I had to remove this line and the Target element below (with the name EnsureNuGetPackageBuildImports) otherwise I got complaints about "This project references NuGet package(s) that are missing on this computer. ...The missing file is ..\packages\NUnit.3.10.1\build\NUnit.props." when compiling.
JohanLarsson
force-pushed
the
new_project_format
branch
from
97dc4ca
to
dcff182
Compare
No description provided.