Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fixes #228

Merged
merged 1 commit into from
May 5, 2020
Merged

Tests fixes #228

merged 1 commit into from
May 5, 2020

Conversation

Dreamescaper
Copy link
Member

Replaced all AnalyzerAssert.NoAnalyzerDiagnostics usages with AnalyzerAssert.Valid, unless test is specifically for error case handling.

It revealed couple of errors in tests, which I fixed.

mikkelbu
mikkelbu approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for improving the tests.

@mikkelbu mikkelbu merged commit fe92a6e into nunit:master May 5, 2020
@mikkelbu mikkelbu added this to the Release 0.3 milestone May 5, 2020
@Dreamescaper Dreamescaper deleted the tests_fixes branch May 6, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkelbu mikkelbu mikkelbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Dreamescaper @mikkelbu