New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EqualToIncompatibleTypesAnalyzer false positive #229

Merged

mikkelbu merged 1 commit into nunit:master from Dreamescaper:fix_EqualToIncompatibleTypesAnalyzer_false_positive

May 5, 2020

Member

Dreamescaper commented May 4, 2020

var actual = new[] { 1,2,2,1 };
Assert.That(actual, Has.All.EqualTo(1).Or.EqualTo(2));

Currently it shows warning for EqualTo(2).

Caused by #218 . I haven't figured out how to fix that issue properly so far, so adding this micro fix to analyzer itself.


          Fix EqualToIncompatibleTypesAnalyzer false positive

1a004f7

mikkelbu approved these changes

View reviewed changes

Member

mikkelbu left a comment

LGTM. Thanks @Dreamescaper

mikkelbu merged commit 992a7f3 into nunit:master

mikkelbu added this to the Release 0.3 milestone

Dreamescaper deleted the fix_EqualToIncompatibleTypesAnalyzer_false_positive branch

May 6, 2020 18:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet