Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add diagnostic for simple test method with parameters #254

Merged
merged 2 commits into from
Jul 16, 2020
Merged

feat: Add diagnostic for simple test method with parameters #254

merged 2 commits into from
Jul 16, 2020

Conversation

mikkelbu
Copy link
Member

Fixes #215

Dreamescaper
Dreamescaper approved these changes Jul 12, 2020
View reviewed changes
Copy link
Member

@Dreamescaper Dreamescaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added couple of nit comments.

src/nunit.analyzers/Constants/TestMethodUsageAnalyzerConstants.cs Show resolved Hide resolved
src/nunit.analyzers/TestMethodUsage/TestMethodUsageAnalyzer.cs Show resolved Hide resolved
src/nunit.analyzers/TestMethodUsage/TestMethodUsageAnalyzer.cs Outdated Show resolved Hide resolved
@mikkelbu mikkelbu added this to the Release 0.4 milestone Jul 16, 2020
@mikkelbu mikkelbu merged commit 150b943 into nunit:master Jul 16, 2020
@mikkelbu mikkelbu deleted the feat/add-diagnostic-simple-method-with-parameters branch July 16, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dreamescaper Dreamescaper Dreamescaper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.4
Development

Successfully merging this pull request may close these issues.

Expected a warning when no arguments are specified for a parameterized test method
2 participants
@mikkelbu @Dreamescaper