Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace link to ruleset docs #516

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Replace link to ruleset docs #516

merged 1 commit into from
Feb 20, 2023

Conversation

SeanKilleen
Copy link
Member

I noticed as part of nunit/docs#723 that the analyzers appear to have an older link.

The MSDN link listed now redirects to https://learn.microsoft.com/en-us/previous-versions/visualstudio/visual-studio-2015/code-quality/walkthrough-configuring-and-using-a-custom-rule-set?view=vs-2015&redirectedfrom=MSDN

I'm proposing using this newer link, which I think achieves the same purpose: https://learn.microsoft.com/en-us/visualstudio/code-quality/using-rule-sets-to-group-code-analysis-rules?view=vs-2022

The analyzer docs eventually flow into the NUnit docs so I figured I'd suggest the change here.

Copy link
Member

@manfred-brands manfred-brands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.

@stevenaw
Copy link
Member

Nice catch!

Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR Sean. I'll merge it now (and then update the two new documentation documents)

@mikkelbu mikkelbu merged commit ca23e38 into master Feb 20, 2023
@mikkelbu mikkelbu added this to the Release 3.6 / 2.6 milestone Feb 20, 2023
@mikkelbu mikkelbu deleted the update-ruleset-link branch February 21, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants