Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Within usage analyzer + tests + codefix #537

Merged
merged 5 commits into from
May 2, 2023
Merged

Within usage analyzer + tests + codefix #537

merged 5 commits into from
May 2, 2023

Conversation

manfred-brands
Copy link
Member

Fixes #344

Rebased original code from #362 from @Antash, fixed rebase issues.
Then addressed remaining issues raised by @mikkelbu

@manfred-brands manfred-brands changed the title Issue 344 Within usage analyzer + tests + codefix Apr 30, 2023
@manfred-brands manfred-brands mentioned this pull request Apr 30, 2023
Closed
@manfred-brands
Exclude System.Collections.Immutable test on NETFRAMEWORK
99d8d60 
Not sure how to pass additional NuGet packages to RoslynAssert.
mikkelbu
mikkelbu approved these changes Apr 30, 2023
View reviewed changes
Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for rebasing and adding the last part. I only have minor nit-pick (probably due to the age of the original change).

src/nunit.analyzers/WithinUsage/WithinUsageAnalyzer.cs Outdated Show resolved Hide resolved
@manfred-brands manfred-brands merged commit 6c49665 into nunit:master May 2, 2023
@manfred-brands manfred-brands deleted the issue-344 branch May 2, 2023 03:46
@mikkelbu mikkelbu added this to the Release 3.7 / 2.7 milestone May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkelbu mikkelbu mikkelbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.7 / 2.7
Development

Successfully merging this pull request may close these issues.

Add a rule informing that .Within is not valid for non-numeric types.
3 participants
@manfred-brands @mikkelbu @Antash