Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ValuesUsageAnalyzer. #570

Merged
merged 19 commits into from
Aug 29, 2023
Merged

Create ValuesUsageAnalyzer. #570

merged 19 commits into from
Aug 29, 2023

Commits on Aug 19, 2023

  1. Create ValuesUsageAnalyzer.cs and add basic test. Implementation does… 

    … not yet do anything but basic structure is in place.
    @manfred-brands
    Andrew McClement authored and manfred-brands committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    a075e67 View commit details
    Browse the repository at this point in the history

  2. Fix up ValuesUsageAnalyzerConstants.cs (remove unused options, correc… 

    …t messages).
    @manfred-brands
    Andrew McClement authored and manfred-brands committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    817941a View commit details
    Browse the repository at this point in the history

  3. Copy patterns from TestCaseUsageAnalyzer instead of ValueSourceUsageA… 

    …nalyzer. Add functioning test cases.
    @manfred-brands
    Andrew McClement authored and manfred-brands committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    5e4e5a5 View commit details
    Browse the repository at this point in the history

  4. Add tests, mimicking tests from TestCaseUsageAnalyzerTests.

    @manfred-brands
    Andrew McClement authored and manfred-brands committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    47e0e9b View commit details
    Browse the repository at this point in the history

  5. Fix up all tests. AnalyzeWhenArgumentPassesNullToValueType reports ob… 

    …ject?[] for the wrong type for [Values(null)] - can we do better?
    @manfred-brands
    Andrew McClement authored and manfred-brands committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    218d804 View commit details
    Browse the repository at this point in the history

  6. Remove unused code.

    @manfred-brands
    Andrew McClement authored and manfred-brands committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    ee744d6 View commit details
    Browse the repository at this point in the history

  7. Tidy names of classes.

    @manfred-brands
    Andrew McClement authored and manfred-brands committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    daa68a3 View commit details
    Browse the repository at this point in the history

  8. Fix up failing tests in NUnitFrameworkConstantsTests.cs.

    @manfred-brands
    Andrew McClement authored and manfred-brands committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    4a253f9 View commit details
    Browse the repository at this point in the history

  9. Add documentation for NUnit2048.

    @manfred-brands
    Andrew McClement authored and manfred-brands committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    01057af View commit details
    Browse the repository at this point in the history

  10. Rename NUnit2048 to NUnit1031, since it reports a structural issue, n… 

    …ot improving an assertion.
    @manfred-brands
    Andrew McClement authored and manfred-brands committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    fdfe3da View commit details
    Browse the repository at this point in the history

  11. Add NUnit1031 to index.md.

    @manfred-brands
    Andrew McClement authored and manfred-brands committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    c656890 View commit details
    Browse the repository at this point in the history

  12. Fix erroneous whitespace change in index.md.

    @manfred-brands
    Andrew McClement authored and manfred-brands committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    772cf08 View commit details
    Browse the repository at this point in the history

  13. Tidy NUnit1031.md.

    @manfred-brands
    Andrew McClement authored and manfred-brands committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    7f92e07 View commit details
    Browse the repository at this point in the history

  14. Re-align with 1001 version

    @manfred-brands
    manfred-brands committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    fc41e94 View commit details
    Browse the repository at this point in the history

  15. Fix test to reflect change in CustomTypeConverter assumptions.

    @manfred-brands
    manfred-brands committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    dafd8e6 View commit details
    Browse the repository at this point in the history

  16. Prevent polluting the nunit test output unnecessary.

    @manfred-brands
    manfred-brands committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    66817af View commit details
    Browse the repository at this point in the history

  17. Added support for Nullable to TestCaseUsageAnalyzer 

    Moved AdjustArguments to re-usable extension method.
Added GetAdjustedArgumentSyntax to get proper argument from explicit array parameters

Added unit tests for explicit array parameters
Added unit tests for nullable
    @manfred-brands
    manfred-brands committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    d29dd57 View commit details
    Browse the repository at this point in the history

  18. ValueUsageAnalyzer now also calls AdjustArguments 

    Added unit tests for explicit array parameters
Added unit tests for nullable
    @manfred-brands
    manfred-brands committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    965e191 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Mikkel Nylander Bundgaard <mikkelbu@users.noreply.github.com>
    @manfred-brands @mikkelbu
    manfred-brands and mikkelbu authored Aug 29, 2023
    Configuration menu
    Copy the full SHA
    f3d9c74 View commit details
    Browse the repository at this point in the history