Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize assignments inside try/finally statements. #583

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,37 @@ public void Test()
RoslynAssert.Suppressed(suppressor, testCode);
}

[Test]
public void FieldAssignedInTryFinally()
manfred-brands marked this conversation as resolved.
Show resolved Hide resolved
{
var testCode = TestUtility.WrapMethodInClassNamespaceAndAddUsings(@"
private string ↓field1;
private string ↓field2;

[SetUp]
public void SetUp()
{
try
{
field1 = ""NUnit"";
}
finally
{
field2 = ""Analyzers"";
}
}

[Test]
public void Test()
{
Assert.That(field1, Is.Not.Null);
Assert.That(field2, Is.Not.Null);
}
");

RoslynAssert.Suppressed(suppressor, testCode);
}

[Test]
public void PropertyNotAssigned()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -127,18 +127,49 @@ private static bool IsAssignedIn(
return IsAssignedIn(model, classDeclaration, method.ExpressionBody.Expression, fieldOrPropertyName);
}

if (method.Body is null)
if (method.Body is not null)
{
return false;
return IsAssignedIn(model, classDeclaration, method.Body, fieldOrPropertyName);
}

foreach (var statement in method.Body.Statements)
return false;
}

private static bool IsAssignedIn(
SemanticModel model,
ClassDeclarationSyntax classDeclaration,
StatementSyntax statement,
string fieldOrPropertyName)
{
switch (statement)
{
if (statement is ExpressionStatementSyntax expressionStatement &&
IsAssignedIn(model, classDeclaration, expressionStatement.Expression, fieldOrPropertyName))
{
case ExpressionStatementSyntax expressionStatement:
return IsAssignedIn(model, classDeclaration, expressionStatement.Expression, fieldOrPropertyName);

case BlockSyntax block:
return IsAssignedIn(model, classDeclaration, block.Statements, fieldOrPropertyName);

case TryStatementSyntax tryStatement:
return IsAssignedIn(model, classDeclaration, tryStatement.Block, fieldOrPropertyName) ||
(tryStatement.Finally is not null &&
IsAssignedIn(model, classDeclaration, tryStatement.Finally.Block, fieldOrPropertyName));

default:
// Any conditional statement does not guarantee assignment.
return false;
}
}

private static bool IsAssignedIn(
SemanticModel model,
ClassDeclarationSyntax classDeclaration,
SyntaxList<StatementSyntax> statements,
string fieldOrPropertyName)
{
foreach (var statement in statements)
{
if (IsAssignedIn(model, classDeclaration, statement, fieldOrPropertyName))
return true;
}
}

return false;
Expand Down