Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also look at static methods for NUnit1032 #613

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Also look at static methods for NUnit1032 #613

merged 1 commit into from
Oct 20, 2023

Conversation

manfred-brands
Copy link
Member

Fixes #607

Change is small, new tests were more work,

mikkelbu
mikkelbu approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix @manfred-brands

@mikkelbu mikkelbu merged commit 42f733f into nunit:master Oct 20, 2023
4 checks passed
@mikkelbu mikkelbu added this to the Release 3.9 / 2.9 milestone Oct 20, 2023
@manfred-brands manfred-brands deleted the Issue607_StaticClasses branch October 21, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkelbu mikkelbu mikkelbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.9 / 2.9
Development

Successfully merging this pull request may close these issues.

NUnit1032 false positive when test class is static
2 participants
@manfred-brands @mikkelbu