Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Refactor tests tryout #73

Closed
wants to merge 2 commits into from
Closed

[WIP] Refactor tests tryout #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab37e88
2 Tryouts simplify tests
304NotModified Aug 21, 2018
2fa259d
C#7 destruct
304NotModified Aug 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 28 additions & 5 deletions src/nunit.analyzers.tests/Extensions/AttributeArgumentSyntaxExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
using System;
using System.IO;
using System.Linq;
using System.Threading.Tasks;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using NUnit.Analyzers.Extensions;
using NUnit.Analyzers.Tests.Targets.Extensions;
using NUnit.Framework;

namespace NUnit.Analyzers.Tests.Extensions
Expand Down Expand Up @@ -201,22 +203,43 @@ private async static Task<Tuple<AttributeArgumentSyntax, ITypeSymbol, SemanticMo
rootAndModel.Item2);
}

private async static Task<(AttributeArgumentSyntax Syntax, ITypeSymbol Symbol, SemanticModel Model)> GetAttributeSyntaxAsync<T>()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: this is just a duplicate for demo purpose.

{
var file = GetTestFileName<T>();
var rootAndModel = await TestHelpers.GetRootAndModel(file);

// It's assumed the code will have one attribute with one argument,
// along with one method with one parameter
return (rootAndModel.Item1.DescendantNodes().OfType<AttributeSyntax>().Single(
_ => _.Name.ToFullString() == "Arguments")
.DescendantNodes().OfType<AttributeArgumentSyntax>().Single(),
rootAndModel.Item2.GetDeclaredSymbol(
rootAndModel.Item1.DescendantNodes().OfType<MethodDeclarationSyntax>().Single()).Parameters[0].Type,
rootAndModel.Item2);
}


[Test]
public async Task CanAssignToWhenArgumentIsImplicitlyTypedArrayAndAssignable()
{
var values = await AttributeArgumentSyntaxExtensionsTests.GetAttributeSyntaxAsync(
$"{AttributeArgumentSyntaxExtensionsTests.BasePath}{(nameof(this.CanAssignToWhenArgumentIsImplicitlyTypedArrayAndAssignable))}.cs");
//option 1
var fileName = GetTestFileName<CanAssignToWhenArgumentIsImplicitlyTypedArrayAndAssignable>();
var values = await GetAttributeSyntaxAsync(fileName);

Assert.That(values.Item1.CanAssignTo(values.Item2, values.Item3), Is.True);
}

[Test]
public async Task CanAssignToWhenArgumentIsImplicitlyTypedArrayAndNotAssignable()
{
var values = await AttributeArgumentSyntaxExtensionsTests.GetAttributeSyntaxAsync(
$"{AttributeArgumentSyntaxExtensionsTests.BasePath}{(nameof(this.CanAssignToWhenArgumentIsImplicitlyTypedArrayAndNotAssignable))}.cs");
// option 2
var (syntax, symbol, model) = await GetAttributeSyntaxAsync<CanAssignToWhenArgumentIsImplicitlyTypedArrayAndNotAssignable>();
Assert.That(syntax.CanAssignTo(symbol, model), Is.False);
}

Assert.That(values.Item1.CanAssignTo(values.Item2, values.Item3), Is.False);
private static string GetTestFileName<T>()
{
return Path.Combine(BasePath, typeof(T).Name.ToString() + ".cs");
}
}
}
2 changes: 1 addition & 1 deletion ...entIsImplicitlyTypedArrayAndAssignable.cs → ...entIsImplicitlyTypedArrayAndAssignable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace NUnit.Analyzers.Tests.Targets.Extensions
{
public sealed class AttributeArgumentSyntaxExtensionsTestsCanAssignToWhenArgumentIsImplicitlyTypedArrayAndAssignable
public sealed class CanAssignToWhenArgumentIsImplicitlyTypedArrayAndAssignable
{
[Arguments(new[] { "a", "b", "c" })]
public void Foo(string[] inputs) { }
Expand Down
2 changes: 1 addition & 1 deletion ...IsImplicitlyTypedArrayAndNotAssignable.cs → ...IsImplicitlyTypedArrayAndNotAssignable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace NUnit.Analyzers.Tests.Targets.Extensions
{
public sealed class AttributeArgumentSyntaxExtensionsTestsCanAssignToWhenArgumentIsImplicitlyTypedArrayAndNotAssignable
public sealed class CanAssignToWhenArgumentIsImplicitlyTypedArrayAndNotAssignable
{
[Arguments(new[] { "a", "b", "c" })]
public void Foo(int[] inputs) { }
Expand Down
8 changes: 4 additions & 4 deletions src/nunit.analyzers.tests/nunit.analyzers.tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@
<Compile Remove="Targets\ClassicModelAssertUsage\IsTrueAndTrueClassicModelAssertUsageCodeFixTestsVerifyGetFixes.cs" />
<Compile Remove="Targets\ClassicModelAssertUsage\IsTrueAndTrueClassicModelAssertUsageCodeFixTestsVerifyGetFixesWithMessage.cs" />
<Compile Remove="Targets\ClassicModelAssertUsage\IsTrueAndTrueClassicModelAssertUsageCodeFixTestsVerifyGetFixesWithMessageAndParams.cs" />
<Compile Remove="Targets\Extensions\AttributeArgumentSyntaxExtensionsTestsCanAssignToWhenArgumentIsImplicitlyTypedArrayAndAssignable.cs" />
<Compile Remove="Targets\Extensions\AttributeArgumentSyntaxExtensionsTestsCanAssignToWhenArgumentIsImplicitlyTypedArrayAndNotAssignable.cs" />
<Compile Remove="Targets\Extensions\AttributeArgumentSyntaxExtensionsTestsCanAssignToWhenArgumentIsNotAssignable.cs" />
<Compile Remove="Targets\Extensions\AttributeArgumentSyntaxExtensionsTestsCanAssignToWhenArgumentIsNotNullableAndAssignable.cs" />
<Compile Remove="Targets\Extensions\AttributeArgumentSyntaxExtensionsTestsCanAssignToWhenArgumentIsNullableAndAssignable.cs" />
Expand All @@ -57,6 +55,8 @@
<Compile Remove="Targets\Extensions\AttributeArgumentSyntaxExtensionsTestsCanAssignToWhenParameterIsTimeSpanAndArgumentIsValidString.cs" />
<Compile Remove="Targets\Extensions\AttributeSyntaxExtensionsTestsGetArguments.cs" />
<Compile Remove="Targets\Extensions\AttributeSyntaxExtensionsTestsGetArgumentsWhenNoneExist.cs" />
<Compile Remove="Targets\Extensions\CanAssignToWhenArgumentIsImplicitlyTypedArrayAndAssignable.cs" />
<Compile Remove="Targets\Extensions\CanAssignToWhenArgumentIsImplicitlyTypedArrayAndNotAssignable.cs" />
<Compile Remove="Targets\Extensions\IMethodSymbolExtensionsTestsGetParameterCounts.cs" />
<Compile Remove="Targets\Extensions\ITypeSymbolExtensionsTestsIsAssertWhenSymbolIsAssertType.cs" />
<Compile Remove="Targets\Extensions\ITypeSymbolExtensionsTestsIsAssertWhenSymbolIsInNUnitAssemblyAndNotAssertType.cs" />
Expand Down Expand Up @@ -175,10 +175,10 @@
<None Include="Targets\ClassicModelAssertUsage\IsTrueAndTrueClassicModelAssertUsageCodeFixTestsVerifyGetFixesWithMessageAndParams.cs">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Include="Targets\Extensions\AttributeArgumentSyntaxExtensionsTestsCanAssignToWhenArgumentIsImplicitlyTypedArrayAndAssignable.cs">
<None Include="Targets\Extensions\AttributeArgumentSyntaxExtensionsTests\CanAssignToWhenArgumentIsImplicitlyTypedArrayAndAssignable.cs">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Include="Targets\Extensions\AttributeArgumentSyntaxExtensionsTestsCanAssignToWhenArgumentIsImplicitlyTypedArrayAndNotAssignable.cs">
<None Include="Targets\Extensions\AttributeArgumentSyntaxExtensionsTests\CanAssignToWhenArgumentIsImplicitlyTypedArrayAndNotAssignable.cs">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Include="Targets\Extensions\AttributeArgumentSyntaxExtensionsTestsCanAssignToWhenArgumentIsNotAssignable.cs">
Expand Down