Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move NUnit4 paragraph under table. #738

Merged
merged 2 commits into from
May 7, 2024
Merged

Move NUnit4 paragraph under table. #738

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24172bb
Move NUnit4 paragraph under table.
manfred-brands May 3, 2024
8db2a32
Added Assume.That
manfred-brands May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions documentation/NUnit2050.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,6 @@ This analyzer needs to be run when still building against NUnit3 as otherwise yo
When usages of the new methods with `params` are detected, the associated CodeFix will convert the format specification
into an interpolated string.

Once you moved to NUnit4 the analyzer has some limited functionality as there are a few
cases where your NUnit3 code will compile on NUnit4, but not the way you want it.
Here what you think are parameters to a format specification are actually interpreted as
the _actual_ and _constraint_ expression strings.
Unfortunately you only find that out when the test fails, which could be never.

The affected methods are:

```csharp
Expand All @@ -48,6 +42,12 @@ Assert.That
Assume.That
```

Once you moved to NUnit4 the analyzer has some limited functionality as there are a few
cases with `Assert.That` where your NUnit3 code will compile on NUnit4, but not the way you want it.
Here what you think are parameters to a format specification are actually interpreted as
the _actual_ and _constraint_ expression strings.
Unfortunately you only find that out when the test fails, which could be never.

## How to fix violations

The following code, valid in NUnit3:
Expand Down