Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NUnit1032: Explain how to dispose fields when using InstancePerTestCase #757

Merged
merged 4 commits into from
Jun 9, 2024
Merged

NUnit1032: Explain how to dispose fields when using InstancePerTestCase #757

merged 4 commits into from
Jun 9, 2024

Conversation

manfred-brands
Copy link
Member

Fixes #756

mikkelbu
mikkelbu approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I have some suggestions, but nothing major. Happy to merge when you are 👍

documentation/NUnit1032.md Outdated Show resolved Hide resolved
@mikkelbu mikkelbu added this to the Release 4.3 milestone Jun 7, 2024
manfred-brands and others added 2 commits June 9, 2024 12:04
@manfred-brands @mikkelbu
Update documentation/NUnit1032.md
40ce030 
Co-authored-by: Mikkel Nylander Bundgaard <mikkelbu@users.noreply.github.com>
@manfred-brands
Wrapped line
decd712
@manfred-brands manfred-brands merged commit 1a135a9 into nunit:master Jun 9, 2024
6 checks passed
@manfred-brands manfred-brands deleted the Issue756_ClarifyNUnit1032 branch June 9, 2024 05:05
@manfred-brands
Copy link
Member Author

Thanks @mikkelbu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkelbu mikkelbu mikkelbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 4.3
Development

Successfully merging this pull request may close these issues.

error NUnit1032 is incorrect when InstancePerTestCase and constructor is used to initialize IDisposible
2 participants
@manfred-brands @mikkelbu