Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give all analyzers unique identifiers #85

Merged
merged 1 commit into from
Dec 16, 2018

Conversation

mikkelbu
Copy link
Member

@mikkelbu mikkelbu commented Dec 16, 2018

In order to use Gu.Roslyn.Asserts to make tests more succient, and
also to reduce the "magic" in the tests, we need that all analyzers
have unique identifers.

This PR just makes all the identifers unique, in a subsequent PR
we'll make use of Gu.Roslyn.Asserts.

Note that #84 will reassign the identifiers once more.

See GuOrg/Gu.Roslyn.Asserts#99 for a little context.

In order to use Gu.Roslyn.Asserts to make tests more succient, and
also to reduce the "magic" in the tests, we need that all analyzers
have unique identifers.

This PR just makes all the identifers unique, in a subsequent PR
we'll make use of Gu.Roslyn.Asserts.

See GuOrg/Gu.Roslyn.Asserts#99 for a little context.
@mikkelbu mikkelbu merged commit 11b30af into nunit:master Dec 16, 2018
@mikkelbu mikkelbu deleted the make-all-identifiers-unique branch December 16, 2018 19:16
@mikkelbu mikkelbu added this to the Release 0.2 milestone Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant