-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n Support Added #60
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: zubairrafi <walleeva2018@gmail.com>
Signed-off-by: zubairrafi <walleeva2018@gmail.com>
Signed-off-by: zubairrafi <walleeva2018@gmail.com>
Signed-off-by: zubairrafi <walleeva2018@gmail.com>
Signed-off-by: zubairrafi <walleeva2018@gmail.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
First of all thanks for the PR. I have not gone through the code. From only seeing the UI my thoughts are
|
To clear our thought about url translaitonTo check popular website how the impolemnt |
So keeping the names of the files similar will hamper the SEO performance. We can check for indexes I guess. To fetch blogs we can check lang and index from the current route. In this way we can update the URLs in locale language without changing the structure of the project. Is it viable? |
For one language Should We even show the language switcher?? |
As this repo will work as a template. We can have at least two language support in this repo and a language switcher. If anyone want to use only for one language they can remove it. Or we can give a simple on and off option in out nuxt config to disable the multi language support |
Signed-off-by: zubairrafi <walleeva2018@gmail.com>
Hey @nurRiyad Things I Have Fixed
Things to look out for
Let me know what you think of these changes. If you want I can re-work and make it as you like hopefully |
I think it's build failing. Need to check @walleeva2018 |
@nurRiyad As I mentioned Above why the build fails. Let me elaborate suppose my blogs site has 6 English Blog and 4 German. Now If I switch to German I will still be able to see the 2 extra English Blogs in proper order. Now I Make language switch in any page missing translation is handled logically. But what pre-renderer do is search for that missing translation which is not there thats why the build fail . 404 for pre-renderer is still a open issue in Nuxt Content Here Possible Solution :
What do you think? Or Am I missing Any better method? |
This PR solves the following Issue
What is Added
File level changes
$t
for showing texts