-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[T10-1] Task Scheduler #106
base: master
Are you sure you want to change the base?
[T10-1] Task Scheduler #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis CI is still failing. Please fix the checkStyle issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see that you have fixed the errors arising from check styles. Good job! Please try to fix the errors from test as well.
seedu.address.storage.JsonUserPrefsStorageTest > readUserPrefs_fileInOrder_successfullyRead FAILED java.lang.AssertionError at JsonUserPrefsStorageTest.java:65
seedu.address.storage.JsonUserPrefsStorageTest > readUserPrefs_extraValuesInFile_extraValuesIgnored FAILED java.lang.AssertionError at JsonUserPrefsStorageTest.java:79
Hope to see contributions from all team members.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see you guys have fixed the Travis CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure the Travis CI build on master branch never fails. If something fails, the PR should not be merged under any circumstance. You are suggested to open branch protection on master branch.
Change implementation of To Do List Commands in Logic
two test cases in ShowDescriptionCommandTest cannot pass
Add Agenda to README libraries used
* Docs: fix tag error
Update Docs
Update Dev Guide.
change personUtil -> calendareventUtil
manual testing
@bryanwongweiheng @SleepySanjinLi @vig42 @pangjiahao