Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[T10-1] Task Scheduler #106

Open
wants to merge 573 commits into
base: master
Choose a base branch
from

Conversation

bryanwongweiheng
Copy link

Copy link

@yunpengn yunpengn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis CI is still failing. Please fix the checkStyle issues.

Copy link

@yunpengn yunpengn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see that you have fixed the errors arising from check styles. Good job! Please try to fix the errors from test as well.

seedu.address.storage.JsonUserPrefsStorageTest > readUserPrefs_fileInOrder_successfullyRead FAILED java.lang.AssertionError at JsonUserPrefsStorageTest.java:65

seedu.address.storage.JsonUserPrefsStorageTest > readUserPrefs_extraValuesInFile_extraValuesIgnored FAILED java.lang.AssertionError at JsonUserPrefsStorageTest.java:79

Hope to see contributions from all team members.

Copy link

@yunpengn yunpengn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see you guys have fixed the Travis CI.

Copy link

@yunpengn yunpengn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see your progress so far.

  • Contact Us page not updated.
  • User Guide good job so far, have described most features.
  • Developed Guide may need more details.

image

image

Copy link

@yunpengn yunpengn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the Travis CI build on master branch never fails. If something fails, the PR should not be merged under any circumstance. You are suggested to open branch protection on master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants