[T13-3] JxMusic #116
Open
[T13-3] JxMusic #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
*Overall
Good start, Team. However, some areas need more work. Hope you can tackle those areas in upcoming features.
You seem to have a lot of features. Make sure that you scope out your work properly for each version.
You can consider skipping some of the less important features or push to v2.0.
Some detailed feedback:
- ReadMe adoc
- Homepage still has AB-4 as the product name.
- Travis build status badge should point to the build status of your own repo, not se-edu/AB-4.
Other badges should be updated to match their project or removed. - Update product description. Still refers to AB-4
- AB-4 should be acknowledged in the Acknowledgements section
- Contact Us adoc
- Update details and links
- About Us adoc
- Roles and components must be assigned to members
- UserGuide adoc
- Update By: Since: at the beginning of the page
- Update Introduction and Quick Start sections to reflect your product's
- DeveloperGuide adoc
- Update Product Scope and value proposition to be your product's
- Grammar check on Use cases
- Update NFR and Glossary
docs/AboutUs.adoc
Outdated
| @@ -4,7 +4,7 @@ | |||
| :imagesDir: images | |||
| :stylesDir: stylesheets | |||
|
|
|||
| AddressBook - Level 4 was developed by the https://se-edu.github.io/docs/Team.html[se-edu] team. + | |||
| JxMusic(AddressBook - Level 4) was developed by the CS2103-Ay1819S1-T13-3 developer (are we supposed to add links) (https://se-edu.github.io/docs/Team.html[se-edu]) team. + | |||
There was a problem hiding this comment.
What links? Add your portfolio and GitHub links only for now
| 1. User requests to list all the playlists. | ||
| 2. System displays names of all playlists in the library. | ||
| + | ||
| Use case ends. |
There was a problem hiding this comment.
No extensions? What if there are no playlists?
docs/DeveloperGuide.adoc
Outdated
| *Extensions* | ||
|
|
||
| [none] | ||
| * 4a. There is no list matches the name. |
There was a problem hiding this comment.
No list matches the name.
There was a problem hiding this comment.
Feedback for v1.2
- Can update the GitHub link to your product webpage instead of AB-4:
Contact Us
- Update issue tracker link
User guide
- Update commands/descriptions that refer to AB-4 rather than your app's. For e.g.
- Examples should be realistic
Developer guide
- No significant updates from previous milestone
- Not enough new/updated design descriptions and UML diagrams to give feedback on. Please try to add more soon.
- Keep in mind that we discourage low level diagrams that span multiple components. Try to draw diagrams at multiple levels: one that shows component level interactions and others shown low level interactions within one components.
Overall
Work on making the product user-testable soon, and catch up on documentation work. The progress at the moment, at least w.r.t documentation seems a bit behind what is required at this stage 😟
add list tracks command
As LibraryParser is fixed, the PlaylistList and TrackList commands can use multiple words command phrase. Add the commands' cases to LibraryParserTest Fix LogicManagerTest to use PlaylistListCommand instead of ListCommand.
Update gitignore for vscode
Edit DevGuide tags Edit UserGuide tags
As per requirement of v1.4: https://nus-cs2103-ay1819s1.github.io/cs2103-website/admin/project-w13-v14.html
edit devGuide
Previous PPP exceeds limit of 10 pages Shrink my diagrams in dev guide
And Hayden's url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hidingmode @HaydenPhillips @NancyQuris @Gongjie663746
JxMusic v1.1 changelog:
playcommand to play 1 hardcoded track in the/libraryfolderpausecommand to pause the trackstopcommand to stop the trackThe 3 commands are only working on Windows for now, not working on Mac OS. We are planning to resolve the issue by v1.2.