-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hue Koh] iP #456
Open
huekoh
wants to merge
76
commits into
nus-cs2103-AY2324S2:master
Choose a base branch
from
huekoh:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Hue Koh] iP #456
Commits on Jan 7, 2024
-
docs/README.md: Tweak document template
Let's tweak the docs/README.md (which is used as the user guide) to fit Duke better. Specifically, 1. mention product name in the title 2. mention adding a product screenshot and a product intro 3. tweak the flow to describe feature-by-feature
damithc committedJan 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 55f9f9f - Browse repository at this point
Copy the full SHA 55f9f9fView commit details -
damithc authored and damithc committed
Jan 7, 2024 Configuration menu - View commit details
-
Copy full SHA for f837ddb - Browse repository at this point
Copy the full SHA f837ddbView commit details -
Configuration menu - View commit details
-
Copy full SHA for a6f7324 - Browse repository at this point
Copy the full SHA a6f7324View commit details
Commits on Jan 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 61a827b - Browse repository at this point
Copy the full SHA 61a827bView commit details -
Configuration menu - View commit details
-
Copy full SHA for af6c7c5 - Browse repository at this point
Copy the full SHA af6c7c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c856ca2 - Browse repository at this point
Copy the full SHA c856ca2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 79772ec - Browse repository at this point
Copy the full SHA 79772ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for bb1c6e8 - Browse repository at this point
Copy the full SHA bb1c6e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b558e2 - Browse repository at this point
Copy the full SHA 2b558e2View commit details
Commits on Jan 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 67c24ef - Browse repository at this point
Copy the full SHA 67c24efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a5a225 - Browse repository at this point
Copy the full SHA 8a5a225View commit details
Commits on Jan 29, 2024
-
Error handling now handles these: 1. general error 2. index provided is out of range 3. task to be done is already done 4. task to be redone is already not done 5. no index was provided 6. user input add with nothing following up 7. incorrect deadline input format 8. incorrect todo input format 9. incorrect event input format
Configuration menu - View commit details
-
Copy full SHA for e4abdc2 - Browse repository at this point
Copy the full SHA e4abdc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed1370c - Browse repository at this point
Copy the full SHA ed1370cView commit details
Commits on Feb 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for aea83d7 - Browse repository at this point
Copy the full SHA aea83d7View commit details
Commits on Feb 6, 2024
-
Update BMO.java addLog function
The formatter now recognises date time strings with "/" to express dates as valid. Previously, strings containing "/" would throw a format error and not accept it as a valid string
Configuration menu - View commit details
-
Copy full SHA for 492ccfc - Browse repository at this point
Copy the full SHA 492ccfcView commit details -
Create BMO.java formatDateTime function
When user adds a task with a date time variable, the string will be formatted into a LocalDateTime object that is stored in the task object.
Configuration menu - View commit details
-
Copy full SHA for 383e95f - Browse repository at this point
Copy the full SHA 383e95fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b3a931f - Browse repository at this point
Copy the full SHA b3a931fView commit details
Commits on Feb 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 66fdcbd - Browse repository at this point
Copy the full SHA 66fdcbdView commit details
Commits on Feb 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ae27309 - Browse repository at this point
Copy the full SHA ae27309View commit details
Commits on Feb 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 37145eb - Browse repository at this point
Copy the full SHA 37145ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a53c79 - Browse repository at this point
Copy the full SHA 6a53c79View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16a7afd - Browse repository at this point
Copy the full SHA 16a7afdView commit details -
Configuration menu - View commit details
-
Copy full SHA for e5370f5 - Browse repository at this point
Copy the full SHA e5370f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08a57ae - Browse repository at this point
Copy the full SHA 08a57aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f73efc - Browse repository at this point
Copy the full SHA 5f73efcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2378bb2 - Browse repository at this point
Copy the full SHA 2378bb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66051d4 - Browse repository at this point
Copy the full SHA 66051d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 445f021 - Browse repository at this point
Copy the full SHA 445f021View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e4b733 - Browse repository at this point
Copy the full SHA 3e4b733View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f552d2 - Browse repository at this point
Copy the full SHA 4f552d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 908319e - Browse repository at this point
Copy the full SHA 908319eView commit details
Commits on Feb 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4d17dbd - Browse repository at this point
Copy the full SHA 4d17dbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for b770bc2 - Browse repository at this point
Copy the full SHA b770bc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36422eb - Browse repository at this point
Copy the full SHA 36422ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 337914f - Browse repository at this point
Copy the full SHA 337914fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 88cdc9d - Browse repository at this point
Copy the full SHA 88cdc9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 86bb968 - Browse repository at this point
Copy the full SHA 86bb968View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f9badd - Browse repository at this point
Copy the full SHA 9f9baddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 09ddc37 - Browse repository at this point
Copy the full SHA 09ddc37View commit details -
Configuration menu - View commit details
-
Copy full SHA for d69e803 - Browse repository at this point
Copy the full SHA d69e803View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa75aa1 - Browse repository at this point
Copy the full SHA aa75aa1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4174b23 - Browse repository at this point
Copy the full SHA 4174b23View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa3147e - Browse repository at this point
Copy the full SHA fa3147eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c6129d - Browse repository at this point
Copy the full SHA 4c6129dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b5808c5 - Browse repository at this point
Copy the full SHA b5808c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf2b38e - Browse repository at this point
Copy the full SHA bf2b38eView commit details -
Configuration menu - View commit details
-
Copy full SHA for fedd628 - Browse repository at this point
Copy the full SHA fedd628View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b5c008 - Browse repository at this point
Copy the full SHA 3b5c008View commit details
Commits on Feb 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 184bcbf - Browse repository at this point
Copy the full SHA 184bcbfView commit details
Commits on Feb 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a5cb836 - Browse repository at this point
Copy the full SHA a5cb836View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09a4de3 - Browse repository at this point
Copy the full SHA 09a4de3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4d44c7 - Browse repository at this point
Copy the full SHA d4d44c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for df48379 - Browse repository at this point
Copy the full SHA df48379View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a61b24 - Browse repository at this point
Copy the full SHA 0a61b24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 484327e - Browse repository at this point
Copy the full SHA 484327eView commit details
Commits on Feb 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c378142 - Browse repository at this point
Copy the full SHA c378142View commit details -
Add assertions to the BMO, Storage and TaskList classes Several methods in these classes require important assumptions to hold true in order for the program to run. Assertions for these conditions to the code helps the debugging process. Let's add assertions to these classes.
Configuration menu - View commit details
-
Copy full SHA for 2d6c2ab - Browse repository at this point
Copy the full SHA 2d6c2abView commit details -
Parse parse method is too long and handles both input type checking and input format checking. Having smaller methods to handle the different types of possible inputs makes the code more readable. Let's update the parser method to handle only input type checking, and abstract out input format checking to appropriate methods.
Configuration menu - View commit details
-
Copy full SHA for 14be28c - Browse repository at this point
Copy the full SHA 14be28cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f52e71c - Browse repository at this point
Copy the full SHA f52e71cView commit details -
Parse parse method is too long and handles both input type checking and input format checking. Having smaller methods to handle the different types of possible inputs makes the code more readable. Let's update the parser method to handle only input type checking, and abstract out input format checking to appropriate methods.
Configuration menu - View commit details
-
Copy full SHA for 45c213a - Browse repository at this point
Copy the full SHA 45c213aView commit details -
Refactor TaskList.java constructor
TaskList constructor method is too long and has duplicated code. Swapping around the try block to encapsulate the switch block instead of vice versa helps remove duplicate code and improve readability. Let's update the TaskList constructor method and reduce duplicate codes
Configuration menu - View commit details
-
Copy full SHA for c7c93b3 - Browse repository at this point
Copy the full SHA c7c93b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2788eba - Browse repository at this point
Copy the full SHA 2788ebaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12cc784 - Browse repository at this point
Copy the full SHA 12cc784View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3aba4a8 - Browse repository at this point
Copy the full SHA 3aba4a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for aaf84da - Browse repository at this point
Copy the full SHA aaf84daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f8118f - Browse repository at this point
Copy the full SHA 6f8118fView commit details
Commits on Feb 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 74a3e1a - Browse repository at this point
Copy the full SHA 74a3e1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for fd441b7 - Browse repository at this point
Copy the full SHA fd441b7View commit details
Commits on Feb 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 683bdcc - Browse repository at this point
Copy the full SHA 683bdccView commit details
Commits on Feb 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 025a761 - Browse repository at this point
Copy the full SHA 025a761View commit details -
Configuration menu - View commit details
-
Copy full SHA for 868d500 - Browse repository at this point
Copy the full SHA 868d500View commit details -
Configuration menu - View commit details
-
Copy full SHA for 837c9b0 - Browse repository at this point
Copy the full SHA 837c9b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d030bc5 - Browse repository at this point
Copy the full SHA d030bc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05d97c0 - Browse repository at this point
Copy the full SHA 05d97c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5424dd - Browse repository at this point
Copy the full SHA b5424ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for d63d186 - Browse repository at this point
Copy the full SHA d63d186View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.