[Hwww23] iP #467

Hwww23 · 2024-02-06T09:51:42Z

PepegPro

“Your mind is for having ideas, not holding them.” – David Allen (source)

DukePro frees your mind from having to remember things you need to do. It's,

text-based
easy to learn
~~FAST~~SUPER FAST to use

All you need to do is,

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 😉

And it is FREE!

Features:

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)

Let's tweak the docs/README.md (which is used as the user guide) to fit Duke better. Specifically, 1. mention product name in the title 2. mention adding a product screenshot and a product intro 3. tweak the flow to describe feature-by-feature

Update Duke.java Update Event.java Update Todo.java

Javiery3889

Overall, I found your code easy to follow for the most part except for logic in Duke.java as it is quite long. You can consider splitting the class into smaller classes if that makes sense. I noted a few minor coding standard violations too. Press on! 👍

Javiery3889 · 2024-02-06T13:19:58Z

src/main/java/Duke.java

+import java.io.*;
+import java.util.*;


Following our coding standard, imported classes should be listed explicitly. For example,

Suggested change

import java.io.*;

import java.util.*;

import java.io.BufferedReader;

I noticed the same issue in several other places as well.

Javiery3889 · 2024-02-06T13:22:07Z

src/main/java/Duke.java

+                    switch (type) {
+                        case "T":
+                            s = loadInput[2].trim();
+                            task = new Todo(s);
+
+                            if (done.equals("1")) {
+                                task.markAsDone();
+                            }
+
+                            myList.addItem(task);
+                            break;
+                        case "D":
+                            s = loadInput[2].trim();
+                            s1 = loadInput[3].trim();
+                            task = new Deadline(s, s1);
+
+                            if (done.equals("1")) {
+                                task.markAsDone();
+                            }
+
+                            myList.addItem(task);
+                            break;
+                        case "E":
+                            s = loadInput[2].trim();
+                            s1 = loadInput[3].trim();
+                            String s2 = loadInput[4].trim();
+                            task = new Event(s, s1, s2);
+
+                            if (done.equals("1")) {
+                                task.markAsDone();
+                            }
+
+                            myList.addItem(task);
+                            break;
+                    }
+                }


Following our coding standards, case clauses should not have indentation in switch statements.

Javiery3889 · 2024-02-06T13:32:23Z

src/main/java/Task.java

+    public String getStatusIcon() {
+        return (isDone ? "X" : " "); // mark done task with X
+    }


Should the logic in this method be separated instead? Perhaps you can consider using a getter method for the boolean variable isDone and format the output based on the variable in the toString() method.

Javiery3889 · 2024-02-06T13:36:35Z

src/main/java/Event.java

+    protected String start;
+    protected String end;


Any reason why you decided to set the access modifier of these two variables to protected instead of private?

Javiery3889 · 2024-02-06T13:44:40Z

src/main/java/MyList.java

+public class MyList {
+    private List<Task> items;
+
+    public MyList() {
+        this.items = new ArrayList<>();
+    }
+
+    public String addItem(Task t) {
+        this.items.add(t);
+        return "Got it. I've added this task:\n" + t.toString() + "\nNow you have " + this.items.size() + " tasks in the list.";
+    }
+
+    public String getItems() {
+        StringBuilder stringBuilder = new StringBuilder();
+        stringBuilder.append("Here are the tasks in your list:\n");
+        int index = 1;
+
+        for (Task task : this.items) {
+            String itemString = String.format("%d. %s\n", index, task.toString());
+            stringBuilder.append(itemString);
+            index++;
+        }
+
+        return stringBuilder.toString();
+    }
+
+    public String markTask(int index) {
+        if (index < 1 || index > this.items.size()) {
+            return "Number is outside length of list";
+        } else {
+            return "Nice! I've marked this task as done:\n" + this.items.get(index - 1).markAsDone();
+        }
+    }


I like your naming of methods adhere to the coding standard 👍. One small nit would be perhaps to choose between task or item in your method names in this class

Update Deadline.java Update Event.java Update duke.txt

Update Duke.java, MyList.java, Task.java, Todo.java, Deadline.java, Event.java

Update build.gradle

ivan24004 · 2024-02-08T02:40:16Z

src/main/java/duke/MyList.java

+    }
+
+    public MyList(List<Task> t) {
+        this.items = t;


I think this can be omitted from the line

ivan24004 · 2024-02-08T02:42:02Z

src/main/java/duke/Parser.java

+        Request request = getRequest(userInput);
+
+        switch (request) {
+            case BYE:


I think this should be deindented to follow our switch case convention.

ivan24004 · 2024-02-08T02:47:09Z

src/main/java/duke/Event.java

+    public String toString() {
+        DateTimeFormatter customFormatter = DateTimeFormatter.ofPattern("MMM d yyyy h:mma");
+        String formattedDateTime = this.start.format(customFormatter);
+        String formattedDateTime1 = this.end.format(customFormatter);


Perhaps change formattedDateTime1 to something more descriptive, like formattedEndDateTime

ivan24004 · 2024-02-08T02:47:56Z

src/main/java/duke/Storage.java

+            String taskString, byString, dateTimePattern, fromString, toString;
+            Task task;
+
+            switch (type) {


Similar comment as above regarding switch-case indentation.

ivan24004 · 2024-02-08T02:49:21Z

src/test/java/duke/StorageTest.java

+public class StorageTest {
+
+    @Test
+    public void testSaveAndLoad() throws DukeException, IOException {


I don't think this follows our coding standard for naming tests, it should follow the format: featureUnderTest_testScenario_expectedBehavior()

ivan24004 · 2024-02-08T02:50:02Z

src/test/java/duke/ParserTest.java

+public class ParserTest {
+
+    @Test
+    public void testGetRequest() {


I don't think this follows our coding standard for naming tests, it should follow the format: featureUnderTest_testScenario_expectedBehavior()

LWS49 · 2024-02-13T07:59:47Z

src/main/java/duke/MyList.java

+
+    public String markTask(int index) {
+        if (index < 1 || index > this.items.size()) {
+            return "Number is outside length of list";


Would it have been better to throw an exception instead, since this is an error in user input?

LWS49 · 2024-02-13T07:59:57Z

src/main/java/duke/MyList.java

+
+    public String delete(int index) {
+        if (index < 1 || index > this.items.size()) {
+            return "Number is outside length of list";


Same for here

…ava, ParserTest.java and StorageTest.java To adhere to java coding standards.

To implement find function

To resolve a bug with saving task

Added assertions to addTask method in MyList.java and save method in Storage.java. - Ensure that task added into the list should not be null or have an empty description. - Ensure that the list being saved into duke.txt is not null.

Update MyList.java, Storage.java

DeleteCommand.java, FindCommand.java, InvalidCommand.java, ListCommand.java and Mark.java and update Ui.java, Storage.java, Parser.java and Duke.java There were methods that were too long which caused deep nesting in Storage.java and Parser.java. The Command class was added to reduce the length of methods by making parser return a specific child class of the Command class, the required operation is then executed depending on the command class.

Conflicts for different method parameter names.

Add Command class

update Parser.java, MyList.java, Event.java and Deadline.java A requirement to provide support for recurring tasks. Provide a RecurringTask interface for deadlines and events and and implement a scheduler so date time can update automatically

Rename chatbot name

Update user guide

update name of jar file

Storage.java Whether a task was recurring a not was not saved and loaded properly. Implement conditions in Storage.java to load recurring task correctly and made some changes to the save() method in Deadline.java and Event.java for proper saving.

Fix invalid datetime bug, e.g. 2022-03-33 2500 and invalid userinput, e.g. todoabc

damithc and others added 17 commits January 7, 2024 18:33

docs/README.md: Tweak document template

55f9f9f

Let's tweak the docs/README.md (which is used as the user guide) to fit Duke better. Specifically, 1. mention product name in the title 2. mention adding a product screenshot and a product intro 3. tweak the flow to describe feature-by-feature

Add Gradle support

f837ddb

Bump gradle and lib version

a6f7324

add level 0

a9fa3cf

add level 0

0803155

Merge remote-tracking branch 'origin/master'

4b230ec

add level 1

1cfd914

no message

d78df2a

add level 2

2be1daa

add level 3

6e786ff

add level 4

c63f766

testing actual vs expected

98afa3b

add level 5

2e0b7a0

add level 6

0d8cd82

add enum

2374953

Add duke.txt

f316b85

Update Duke.java Update Event.java Update Todo.java

Merge branch 'branch-Level-7'

d4888e8

Javiery3889 reviewed Feb 6, 2024

View reviewed changes

Hwww23 added 6 commits February 7, 2024 00:42

Update Duke.java

3907085

Update Deadline.java Update Event.java Update duke.txt

Merge branch 'branch-Level-8'

0407bb0

Add Ui.java, Storage.java and Parser.java

f08a093

Update Duke.java, MyList.java, Task.java, Todo.java, Deadline.java, Event.java

no message

ec88d65

Add checkstyle.xml, suppressions.xml

2022c05

Update build.gradle

Add duketest.txt, ParserTest.java and StorageTest.java

87756d6

ivan24004 reviewed Feb 8, 2024

View reviewed changes

LWS49 reviewed Feb 13, 2024

View reviewed changes

Hwww23 added 4 commits February 14, 2024 03:42

Add Javadoc comments for code documentation

8ba35b0

Update Deadline.java, Event.java, MyList.java, Parser.java, Storage.j…

a6e1d6f

…ava, ParserTest.java and StorageTest.java To adhere to java coding standards.

Update Mylist.java, Parser.java, Task.java

ef1363a

To implement find function

Merge branch 'branch-A-CodingStandard'

b975d99

Hwww23 added 29 commits February 14, 2024 16:40

Resolve merge conflicts in Parser.java

64a8626

Update Mylist.java, ParserTest.java, StorageTest.java and build.gradle

e4427c7

Added GUI

8184505

Merge branch 'branch-Level-10'

c0aa472

Update README.md

a2ee707

Update README.md

5b8c236

Update README.md

50d9259

Update duke.txt

d2b327c

Update Duke.java and Storage.java

bbdc0b8

To resolve a bug with saving task

Update MyList.java, Storage.java

57bde4e

Added assertions to addTask method in MyList.java and save method in Storage.java. - Ensure that task added into the list should not be null or have an empty description. - Ensure that the list being saved into duke.txt is not null.

Merge pull request #2 from Hwww23/branch-A-Assertions

a981cbc

Update MyList.java, Storage.java

Update Storage.java

c83962e

Conflicts for different method parameter names.

Merge pull request #3 from Hwww23/branch-A-CodeQuality

53bc042

Add Command class

Update README.md

a19afa4

Update README.md

4ce3bfc

Update README.md

7b04824

Update README.md

b8d4090

Add Ui.png

5904fd8

Update Ui.java and Main.java

0ee8811

Rename chatbot name

Update README.md

ea93544

Update README.md

3b83ea6

Update user guide

Update build.gradle

2642eff

update name of jar file

Update README.md

805e1bc

Fix jar

652143b

Fix jar

d264229

Update Parser.java and Duke.java

9bbc727

Fix invalid datetime bug, e.g. 2022-03-33 2500 and invalid userinput, e.g. todoabc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hwww23] iP #467

[Hwww23] iP #467

Hwww23 commented Feb 6, 2024 •

edited

Loading

Javiery3889 left a comment

Javiery3889 Feb 6, 2024

Javiery3889 Feb 6, 2024

Javiery3889 Feb 6, 2024

Javiery3889 Feb 6, 2024 •

edited

Loading

Javiery3889 Feb 6, 2024 •

edited

Loading

ivan24004 Feb 8, 2024

ivan24004 Feb 8, 2024

ivan24004 Feb 8, 2024

ivan24004 Feb 8, 2024

ivan24004 Feb 8, 2024

ivan24004 Feb 8, 2024

LWS49 Feb 13, 2024

LWS49 Feb 13, 2024

	import java.io.*;
	import java.util.*;
	import java.io.BufferedReader;

[Hwww23] iP #467

Are you sure you want to change the base?

[Hwww23] iP #467

Conversation

Hwww23 commented Feb 6, 2024 • edited Loading

PepegPro

Javiery3889 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Javiery3889 Feb 6, 2024 • edited Loading

Choose a reason for hiding this comment

Javiery3889 Feb 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hwww23 commented Feb 6, 2024 •

edited

Loading

Javiery3889 Feb 6, 2024 •

edited

Loading

Javiery3889 Feb 6, 2024 •

edited

Loading