Alex Setyawan iP #476
Alex Setyawan iP #476
Conversation
Let's tweak the docs/README.md (which is used as the user guide) to fit Duke better. Specifically, 1. mention product name in the title 2. mention adding a product screenshot and a product intro 3. tweak the flow to describe feature-by-feature
|
Add code descriptions and change method names such as.. message() to displayMessage? |
src/main/java/Awex.java
Outdated
| import java.util.*; | ||
|
|
||
| public class Awex { | ||
| public static void message() { |
There was a problem hiding this comment.
Good abstraction of the message to display the list of commands available. Perhaps a better and more specific variable name could be used here to describe this function? For example you could rename it to: listAllCommands()
src/main/java/Awex.java
Outdated
|
|
||
| public static void main(String[] args) { | ||
| System.out.println("Hello! I'm AWEX!\nWhat can I do for you?"); | ||
| LinkedList<Task> list = new LinkedList<>(); |
There was a problem hiding this comment.
Any reason why a LinkedList is used instead of an ArrayList? Indeed a LinkedList works similar to an ArrayList, although their use cases may vary depending on the scenario. Here is some research that I did: ArrayList vs LinkedList
src/main/java/Awex.java
Outdated
| @@ -0,0 +1,130 @@ | |||
| import java.util.*; | |||
There was a problem hiding this comment.
Perhaps you could try to avoid the use of wildcard imports here as it could lead to import conflicts.
src/main/java/Awex.java
Outdated
| Scanner sc = new Scanner(System.in); | ||
| String next = sc.nextLine(); | ||
| String[] arr = next.split(" "); | ||
| while (!next.equals("bye")) { |
There was a problem hiding this comment.
Good use of if-else statements to check and parse inputs! However, perhaps you could abstract out this method and also do consider using switch-case statements to improve performance.
src/main/java/DeadlineTask.java
Outdated
| @@ -0,0 +1,12 @@ | |||
| public class DeadlineTask extends Task { | |||
Currently, all logic of command identification is done in Awex.getResponse() method This leads to getResponse being long and confusing, leading to potential bugs Abstracting each if-else block in the current getResponse method helps for better readability, as well as ease in narrowing down sources of bugs.
Add A-Assertions
…nch-A-CodeQuality
Currently, users always get the instruction message if they type erroneous inputs, regardless if they know how to rectify them. As the instruction message is long, it runs the risk of clogging the conversation space. So a message directing the user to type "help" for full instructions is made, so the user can get advice only when he/she needs it.
AWEX
And that is exactly what using AWEX allows you to do! Why record tasks using a notepad or a calendar, when you can painstakingly download a rudimentary project from online, that provides the exact same functionality?
Notepad? Boring. Overused. Plain.
Chatbot? Cool. Fancy. Sexy.
AWEX (A Wonderful EXperience) revolutionises the way we construct our to-do lists, being
and letting you,
unlike ANY other productivity app! 😱
All you need to do is:
Want to see how we make our tasks? Here's a sneak peek of our
Taskclass!