feat: reintroduce raw-strings #117
Conversation
|
Incorporated all reviews, removed the pipeline changes that neither provide insights nor prevent anything. Maybe pipeline is a separate issue that should be addressed at some point. |
|
Ping me if/when we're ready to land this and I'll push the button. |
|
Thanks to @blindFS for the thorough review! Is there someone else who would want to review? Otherwise, I'd be ready to land, again |
mrdgo
changed the title
|
Aaah, wait a second Edit: okay, now! |
mrdgo
changed the title
val_string is a parent of raw_string_x and already highlighted
|
looks like we're closer, just have a conflict now. |
|
Are we ready? |
I think so. |
|
@clason does nvim-ts' lockfile interfere, even when I override the |
|
Yes, the lockfile takes precedence. (Nvim-ts is not a general purpose installer; you can shoehorn additional parsers but it's not designed for replacing tracked parsers.) |
Would you then pretty-please be so kind 😇 |
|
We have automation for that (Or PR welcome, if queries need to be adapted.) |
This PR fixes #157 . The problem is rooted in my [review suggestion](#117 (comment)), so the change is reverted. But I don't get why, how is whitespaces automatically skipped by `extras` for `$._str_double_quotes`, but not `$._raw_string`. @mrdgo do you have any idea? Edit: I get it wrong, the scanner is handled earlier than `extras` so it may override the behavior of the later.
Discussion with tree-sitter devs
This will break the current
nvim-treesitterconfig. They have to update to also usescanner.c. People using that config might want to use "our" way to install ts-nu.After merge, it might be necessary to run
:TSUpdate nuat least once. I don't know about treesitter's caching, so let's just hope that nobody's setup breaks.With that scanner, we can also create custom logic for unquoted strings.