Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helix support #27

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Helix support #27

merged 2 commits into from
Aug 17, 2023

Conversation

NotLebedev
Copy link
Contributor

@NotLebedev NotLebedev commented Aug 17, 2023 •
edited
Loading

Add installation instruction for helix editor and mention it in README.md.

Add injections.scm query to support TODO and FIXME highlights in comments (see PR discussion):

image

@NotLebedev
Add injections query for helix editor
86c6fe8 
Add injections for comment strings for helix editor. This allows
to highlight TODO and FIXME in comment strings when using editors
supporting this query (e.g. helix)
@NotLebedev
Add installation instructions for helix editor.
ab3bf89
@fdncred
Copy link
Collaborator

fdncred commented Aug 17, 2023

oh, cool! I've been wondering about how to do that. Thanks!

@fdncred fdncred merged commit 786689b into nushell:main Aug 17, 2023
@NotLebedev NotLebedev deleted the helix-support branch August 17, 2023 13:16
@fdncred
Copy link
Collaborator

fdncred commented Aug 17, 2023 •
edited
Loading

I'm kinda wondering if we should just PR our tree-sitter-nu to helix so it's the default? I wonder if it's ready? Oops, I just saw that your reference link was trying to do that. Sorry.

@NotLebedev
Copy link
Contributor Author

I'm kinda wondering if we should just PR our tree-sitter-nu to helix so it's the default? I wonder if it's ready? Oops, I just saw that your reference link was trying to do that. Sorry.

Yeah, already done. I assume 23.08 would release soon and this would be available to public. But even if not, I hope instructions help everyone interested stay up to date with state of affairs in nu grammar despite long release schedule of helix

@fdncred
Copy link
Collaborator

fdncred commented Aug 17, 2023

I just used the instructions with the latest commit-hash and it worked fine with 1 exception. I had to delete the two left over queries that we don't have. The ones from LHKipps versions. Once I did that, and copied the grammars to the right place, things worked correctly.

@NotLebedev
Copy link
Contributor Author

I had to delete the two left over queries that we don't have. The ones from LHKipps versions.

I tried to explain this part in the warning at the end of installation/helix.md. I hoped it would be clear, but maybe I need to rewrite it to be more clear?

@fdncred
Copy link
Collaborator

fdncred commented Aug 17, 2023

Ya, I read that but what didn't occur to me was to delete those 2 scm files. I figured they'd just work with the other ones, even though you said they were incompatible. This a me issue, not an issue with your PR. I would've needed something like, "Delete your existing SCM files and copy the new ones each time you do this.". :)

mrdgo pushed a commit to mrdgo/tree-sitter-nu that referenced this pull request Sep 23, 2024
@fdncred
Merge pull request nushell#27 from NotLebedev/helix-support
7937e8c 
Helix support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NotLebedev @fdncred