Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: migrate to devbox tooling #358

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

faiq
Copy link
Contributor

@faiq faiq commented Jan 10, 2024

What this PR does / why we need it:

This PR moves to using devbox both in CI and locally to manage binary installations. The changes in this PR are as follows:

  1. Introducing devbox
  2. Removing references and scripts to local bin tools, and using the binaries provided by devbox instead.
  3. Documentation changes to note that this project now requires devbox and direnv

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
This makes local development and CI more consistent.

How Has This Been Tested?:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and test output

The CI has previously passed and runs properly.

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@deepakm-ntnx
Copy link
Contributor

deepakm-ntnx commented Jan 10, 2024

@faiq this has conflicts. could you please fix it. also it would be good to update description with the tests done

@faiq faiq force-pushed the devbox-build branch 3 times, most recently from e55f9ae to d70f925 Compare January 11, 2024 16:54
@faiq
Copy link
Contributor Author

faiq commented Jan 11, 2024

/retest

1 similar comment
@faiq
Copy link
Contributor Author

faiq commented Jan 11, 2024

/retest

@faiq
Copy link
Contributor Author

faiq commented Jan 11, 2024

/retest

4 similar comments
@faiq
Copy link
Contributor Author

faiq commented Jan 11, 2024

/retest

@faiq
Copy link
Contributor Author

faiq commented Jan 11, 2024

/retest

@faiq
Copy link
Contributor Author

faiq commented Jan 11, 2024

/retest

@faiq
Copy link
Contributor Author

faiq commented Jan 11, 2024

/retest

@faiq
Copy link
Contributor Author

faiq commented Jan 11, 2024

/retest

@faiq faiq force-pushed the devbox-build branch 2 times, most recently from 8e80a7a to 1247312 Compare January 11, 2024 20:56
@faiq
Copy link
Contributor Author

faiq commented Jan 11, 2024

/retest

@faiq faiq changed the title Migrate to devbox tooling #338 rebased build: migrate to devbox tooling Jan 11, 2024
go.mod Show resolved Hide resolved
devbox.json Outdated Show resolved Hide resolved
devbox.lock Outdated Show resolved Hide resolved
supershal
supershal previously approved these changes Jan 11, 2024
Copy link

@supershal supershal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thunderboltsid
Copy link
Contributor

/test e2e-capx-controller-upgrade

@thunderboltsid
Copy link
Contributor

/test e2e-capx-controller-upgrade

@thunderboltsid
Copy link
Contributor

/test e2e-k8s-upgrade

@faiq faiq force-pushed the devbox-build branch 4 times, most recently from 492c0e1 to 4d62741 Compare January 26, 2024 16:12
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c075eb4) 15.24% compared to head (beef953) 13.70%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
- Coverage   15.24%   13.70%   -1.55%     
==========================================
  Files          18       17       -1     
  Lines        1207     1197      -10     
==========================================
- Hits          184      164      -20     
- Misses       1023     1033      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@supershal supershal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest changes locally. Thank you.

@thunderboltsid
Copy link
Contributor

/retest

@nutanix-cn-prow-bot
Copy link

nutanix-cn-prow-bot bot commented Jan 26, 2024

@faiq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ncn-1-calico-k8s-v1.26.1 28c6441 link false /test e2e-ncn-1-calico-k8s-v1.26.1
ci/prow/e2e-ncn-1-calico-k8s-v1.26-v.1.27 28c6441 link false /test e2e-ncn-1-calico-k8s-v1.26-v.1.27
ci/prow/e2e-ncn-1-calico-k8s-v.1.27-api-upgrade 28c6441 link false /test e2e-ncn-1-calico-k8s-v.1.27-api-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thunderboltsid
Copy link
Contributor

/test e2e-capx-controller-upgrade

Copy link
Contributor

@thunderboltsid thunderboltsid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/woof

@nutanix-cn-prow-bot
Copy link

@thunderboltsid: dog image

In response to this:

/lgtm
/approve
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nutanix-cn-prow-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepakm-ntnx, faiq, supershal, thunderboltsid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [deepakm-ntnx,thunderboltsid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thunderboltsid thunderboltsid merged commit 37a3def into nutanix-cloud-native:main Jan 26, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants