Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Labels for E2E tests #364

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Update Labels for E2E tests #364

merged 1 commit into from
Jan 18, 2024

Conversation

thunderboltsid
Copy link
Contributor

  • Replace 'prblocker' with 'quickstart' to clarify intent
  • Remove 'slow' and 'network' as every test had it making it moot
  • Expand scope of 'capx-feature-test' to target all nutanix interactions
  • Add 'scaling' to target all tests involving node churn

@thunderboltsid
Copy link
Contributor Author

/hold

@thunderboltsid
Copy link
Contributor Author

/retest

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f595774) 15.21% compared to head (2b0d6cd) 15.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #364   +/-   ##
=======================================
  Coverage   15.21%   15.21%           
=======================================
  Files          18       18           
  Lines        1209     1209           
=======================================
  Hits          184      184           
  Misses       1025     1025           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thunderboltsid
Copy link
Contributor Author

/unhold

Copy link
Contributor

@tuxtof tuxtof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Replace 'prblocker' with 'quickstart' to clarify intent
- Remove 'slow' and 'network' as every test had it making it moot
- Expand scope of 'capx-feature-test' to target all nutanix interactions
- Add 'scaling' to target all tests involving node churn
Copy link

✅ None of your dependencies violate policy!

@thunderboltsid thunderboltsid merged commit 72058b8 into main Jan 18, 2024
8 of 9 checks passed
@thunderboltsid thunderboltsid deleted the update-e2e-labels branch January 18, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants