-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Labels for E2E tests #364
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thunderboltsid
commented
Jan 17, 2024
- Replace 'prblocker' with 'quickstart' to clarify intent
- Remove 'slow' and 'network' as every test had it making it moot
- Expand scope of 'capx-feature-test' to target all nutanix interactions
- Add 'scaling' to target all tests involving node churn
/hold |
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
=======================================
Coverage 15.21% 15.21%
=======================================
Files 18 18
Lines 1209 1209
=======================================
Hits 184 184
Misses 1025 1025 ☔ View full report in Codecov by Sentry. |
/unhold |
tuxtof
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Replace 'prblocker' with 'quickstart' to clarify intent - Remove 'slow' and 'network' as every test had it making it moot - Expand scope of 'capx-feature-test' to target all nutanix interactions - Add 'scaling' to target all tests involving node churn
thunderboltsid
force-pushed
the
update-e2e-labels
branch
from
January 18, 2024 13:49
ce26615
to
2b0d6cd
Compare
yannickstruyf3
approved these changes
Jan 18, 2024
✅ None of your dependencies violate policy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.